Skip to content

Conversation

@jorisvandenbossche
Copy link

Similarly as #2727, not to merge, but just to test the pandas release candidate on your CI.

@mwaskom
Copy link
Owner

mwaskom commented Jan 12, 2024

Thanks! Looks like one test failure based on a construct used in a test, easy for seaborn to adapt (although the error message is weird as the capitalization in the error message doesn't match what is in the code — maybe double check that's not a pandas bug?)

But also a tremendous amount of FutureWarning for upcoming deprecations that did not go through a DeprecationWarning schedule :/

@jorisvandenbossche
Copy link
Author

Looks like one test failure based on a construct used in a test, easy for seaborn to adapt (although the error message is weird as the capitalization in the error message doesn't match what is in the code — maybe double check that's not a pandas bug?)

Yes, that's indeed easy to fix here, and have also already reported that on the pandas side: pandas-dev/pandas#56847 (comment). It was not really documented that those lower case versions also work, but it's probably a bug in the deprecation that those stopped working.

@mwaskom
Copy link
Owner

mwaskom commented Jan 21, 2024

Thanks for flagging!

@mwaskom mwaskom closed this Jan 21, 2024
@jorisvandenbossche jorisvandenbossche deleted the test-pandas-2.2-rc branch January 22, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants