Skip to content

[FIXED] Filestore always use tombstone for recovered trailing deletes#7782

Merged
neilalexander merged 1 commit intomainfrom
maurice/fs-index-skip-msg
Feb 2, 2026
Merged

[FIXED] Filestore always use tombstone for recovered trailing deletes#7782
neilalexander merged 1 commit intomainfrom
maurice/fs-index-skip-msg

Conversation

@MauriceVanVeen
Copy link
Copy Markdown
Member

@MauriceVanVeen MauriceVanVeen commented Jan 30, 2026

When restoring from a stale index.db stream state file, we still remember the last sequence that was used. If this last sequence was higher than is currently on disk, we move the recovered lower last sequence up to the highest seen last sequence. However, the last sequence and timestamp were adjusted even if no tombstone was actually written.

Signed-off-by: Maurice van Veen github@mauricevanveen.com

@MauriceVanVeen MauriceVanVeen requested a review from a team as a code owner January 30, 2026 16:30
@MauriceVanVeen MauriceVanVeen marked this pull request as draft January 30, 2026 17:32
@MauriceVanVeen MauriceVanVeen force-pushed the maurice/fs-index-skip-msg branch from 1823f69 to 87e604f Compare February 1, 2026 18:00
@MauriceVanVeen MauriceVanVeen changed the title [FIXED] Filestore uses SkipMsgs for recovered trailing deletes [FIXED] Filestore always use tombstone for recovered trailing deletes Feb 1, 2026
@MauriceVanVeen MauriceVanVeen force-pushed the maurice/fs-index-skip-msg branch from 87e604f to b84c2d6 Compare February 1, 2026 18:05
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
@MauriceVanVeen MauriceVanVeen force-pushed the maurice/fs-index-skip-msg branch from b84c2d6 to 77159a8 Compare February 1, 2026 18:28
@MauriceVanVeen MauriceVanVeen marked this pull request as ready for review February 1, 2026 18:58
Copy link
Copy Markdown
Member

@neilalexander neilalexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@neilalexander neilalexander merged commit bf5a10c into main Feb 2, 2026
111 of 114 checks passed
@neilalexander neilalexander deleted the maurice/fs-index-skip-msg branch February 2, 2026 08:50
neilalexander added a commit that referenced this pull request Feb 16, 2026
Includes the following:

- #7780
- #7784
- #7782
- #7783
- #7787
- #7789
- #7793
- #7797
- #7798
- #7799
- #7790
- #7805
- #7810
- #7811
- #7812
- #7809
- #7724
- #7815
- #7816
- #7818
- #7819
- #7820
- #7795
- #7825
- #7828
- #7835
- #7837

Signed-off-by: Neil Twigg <neil@nats.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants