[FIXED] Inflight meta change tracking#7798
Merged
neilalexander merged 1 commit intomainfrom Feb 5, 2026
Merged
Conversation
Member
neilalexander
left a comment
neilalexander
left a comment
There was a problem hiding this comment.
Overall looks good, just a couple minor things.
server/jetstream_cluster.go
Outdated
|
|
||
| // Will look up a stream assignment, either an applied or inflight assignment. | ||
| // Lock should be held. | ||
| func (js *jetStream) streamAssignmentOrInflight(account, stream string) (sa *streamAssignment) { |
Member
There was a problem hiding this comment.
Can we simplify this to just do early returns instead of overwriting sa? Avoids unnecessary map lookups.
server/jetstream_cluster.go
Outdated
|
|
||
| // Will gather all stream assignments for a specific account, both applied and inflight assignments. | ||
| // Lock should be held. | ||
| func (js *jetStream) streamAssignmentOrInflightSeq(account string) iter.Seq[*streamAssignment] { |
Member
There was a problem hiding this comment.
Minor nit but it might make sense if this function naming is plural, since it returns more than one result. It looks a bit odd in the for loops otherwise.
Member
Author
There was a problem hiding this comment.
Done, renamed to streamAssignmentsOrInflightSeq, similarly for consumerAssignmentsOrInflightSeq.
server/jetstream_cluster.go
Outdated
|
|
||
| // Will look up a consumer assignment, either an applied or inflight assignment. | ||
| // Lock should be held. | ||
| func (js *jetStream) consumerAssignmentOrInflight(account, stream, consumer string) (ca *consumerAssignment) { |
Member
There was a problem hiding this comment.
Same here on early returns.
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
MauriceVanVeen
force-pushed
the
maurice/track-inflight-meta
branch
from
d4f5291 to
cfbbd7b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements proper inflight meta changes tracking. Importantly, this fixes:
Signed-off-by: Maurice van Veen github@mauricevanveen.com