Skip to content

Improve call grid & Picture-inPicture view #4947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mahibi merged 28 commits into from
May 14, 2025
Merged

Improve call grid & Picture-inPicture view #4947

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
b85016a
Rename .java to .kt
mahibi May 5, 2025
7df19b7
convert ParticipantsAdapter to kt
mahibi May 5, 2025
4b8b763
Rename .java to .kt
mahibi May 5, 2025
feeec78
WIP migrate call grid to compose
mahibi May 5, 2025
42a8afd
fix z index of videos and click listener to show controls
mahibi May 5, 2025
aacc013
improve call participants layout
mahibi May 6, 2025
35c777e
move SurfaceViewRenderer into WebRTCVideoView
mahibi May 6, 2025
2741f59
sort participants by audio/video (experimental, commented out)
mahibi May 6, 2025
ecf6d36
calculate item height
mahibi May 6, 2025
bcb276d
add padding to cells
mahibi May 6, 2025
15d7c83
simplify grid cell calculation
mahibi May 6, 2025
91b0e97
show rounded circle for avatar
mahibi May 6, 2025
d546046
add shadow to nick name
mahibi May 6, 2025
1136508
fix voice only call design by workaround.
mahibi May 7, 2025
257dc2a
only show avatars for voiceonly calls
mahibi May 7, 2025
c3b09dd
add background colors like in web to participant tile
mahibi May 7, 2025
af93877
move self video position more to edge
mahibi May 7, 2025
51eb7ed
remove unused constants
mahibi May 7, 2025
1703a34
remove unused code
mahibi May 7, 2025
b6519f6
make sure to release pipSelfVideoRenderer after hangup
mahibi May 7, 2025
38072d4
fix to show screenshare
mahibi May 7, 2025
99d5e5d
clearImage before release surfaceViewRenderer in ParticipantDisplayItem
mahibi May 7, 2025
74d937c
ktlint format + fix lint warning
mahibi May 7, 2025
addb022
remove unused resources
mahibi May 12, 2025
962972d
resolve lint/detekt warnings
mahibi May 12, 2025
eaed930
simplify participant data structure
mahibi May 12, 2025
6a048fd
improve/fix contents for picture in picture mode
mahibi May 13, 2025
31433f8
adapt avatar size to box size
mahibi May 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
249 changes: 108 additions & 141 deletions app/src/main/java/com/nextcloud/talk/activities/CallActivity.kt
View file
Open in desktop

Large diffs are not rendered by default.

203 changes: 0 additions & 203 deletions app/src/main/java/com/nextcloud/talk/adapters/ParticipantDisplayItem.java
View file
Open in desktop

This file was deleted.

Loading
Loading