-
-
Notifications
You must be signed in to change notification settings - Fork 292
Improve call grid & Picture-inPicture view #4947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Marcel Hibbe <[email protected]>
Signed-off-by: Marcel Hibbe <[email protected]>
Signed-off-by: Marcel Hibbe <[email protected]>
Signed-off-by: Marcel Hibbe <[email protected]>
Signed-off-by: Marcel Hibbe <[email protected]>
Signed-off-by: Marcel Hibbe <[email protected]>
Signed-off-by: Marcel Hibbe <[email protected]>
Signed-off-by: Marcel Hibbe <[email protected]>
Signed-off-by: Marcel Hibbe <[email protected]>
Signed-off-by: Marcel Hibbe <[email protected]>
Signed-off-by: Marcel Hibbe <[email protected]>
Signed-off-by: Marcel Hibbe <[email protected]>
Signed-off-by: Marcel Hibbe <[email protected]>
For now, instead to measure height mixed from xml and compose, assume a fixed height for the xml views (callInfosLinearLayout and callControls) to limit the grid height. They is not a nice solution and should be replaced once everything is migrated to compose. Signed-off-by: Marcel Hibbe <[email protected]>
improve pip handling a bit minor changes Signed-off-by: Marcel Hibbe <[email protected]>
Signed-off-by: Marcel Hibbe <[email protected]>
Signed-off-by: Marcel Hibbe <[email protected]>
Signed-off-by: Marcel Hibbe <[email protected]>
Signed-off-by: Marcel Hibbe <[email protected]>
Signed-off-by: Marcel Hibbe <[email protected]>
at least as another cell. fullscreen needs to be implemented Signed-off-by: Marcel Hibbe <[email protected]>
at least as another cell. fullscreen needs to be implemented Signed-off-by: Marcel Hibbe <[email protected]>
Signed-off-by: Marcel Hibbe <[email protected]>
Signed-off-by: Marcel Hibbe <[email protected]>
Signed-off-by: Marcel Hibbe <[email protected]>
move ParticipantUiState into ParticipantDisplayItem Signed-off-by: Marcel Hibbe <[email protected]>
depending on amount of participants, voiceOnly call and enabled/disabled own video, the contents of PIP windows are updated. This will be further improved when speaker-view is implemented. Signed-off-by: Marcel Hibbe <[email protected]>
..by using a BoxWithConstraints Signed-off-by: Marcel Hibbe <[email protected]>
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4947-talk.apk |
sowjanyakch
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess it is caused by the workaround that i used for now (either the condition fails or the hardcoded dp's mess it up). As the calls itself work, i suggest to merge this for now and a fix will follow later today (to be released with RC1 today) or for RC2. I will have to review and merge other PRs that should make it into RC1.. |


This PR migrates the call grid to Compose. (This will avoid handling with wrong video renderer handling in the XML GridView, so it will fix #4916 )
Additionally the Design is made similar to the other platforms (Same background colors for cells...).
This PR could solve other issues related to calls as well, but architecture needs to improve further.
How to test
🖼️ Screenshots
to compare...
Arrangement of cells with different amount of participants and portrait/landscape mode. Scolling is enabled when there are too many participants to match on the screen
🚧 TODO
🏁 Checklist
/backport to stable-xx.x