Skip to content

Conversation

@mahibi
Copy link
Collaborator

@mahibi mahibi commented May 28, 2025

followup to #4947

This will remove the workaround regarding heightForNonGridComponents by using a BoxWithConstraints

πŸ–ΌοΈ Screenshots

🏚️ Before 🏑 After
B A

🚧 TODO

  • ...

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • πŸ”– Capability is checked or not needed
  • πŸ”™ Backport requests are created or not needed: /backport to stable-xx.x
  • πŸ“… Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

this will remove the workaround regarding heightForNonGridComponents by using a BoxWithConstraints

Signed-off-by: Marcel Hibbe <[email protected]>
@mahibi mahibi added this to the 22.0.0 milestone May 28, 2025
@mahibi mahibi self-assigned this May 28, 2025
@mahibi mahibi added the 3. to review Waiting for reviews label May 28, 2025
@mahibi mahibi changed the title simplify call grid design for voice only calls simplify call grid design logic for voice only calls May 28, 2025
@mahibi
Copy link
Collaborator Author

mahibi commented May 28, 2025

with a bit of luck, it may also fix #4947 (comment)
Can you check this @sowjanyakch ? (i was never able to reproduce)

@github-actions
Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/5008-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

@github-actions
Copy link
Contributor

Codacy

Lint

TypemasterPR
Warnings9999
Errors1010

SpotBugs

CategoryBaseNew
Bad practice66
Correctness22216
Dodgy code7167
Internationalization33
Malicious code vulnerability33
Performance44
Security11
Total310100

@rapterjet2004 rapterjet2004 merged commit eb75f48 into master May 29, 2025
18 checks passed
@rapterjet2004 rapterjet2004 deleted the simplifyCallGridLayoutForVoiceOnly branch May 29, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants