Skip to content

Added overflow option in the style panel #1793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 20, 2025

Conversation

SoloDevAbu
Copy link
Contributor

@SoloDevAbu SoloDevAbu commented Apr 17, 2025

Description

Added Overflow options in the style panel

Related Issues

fixes #1532

Type of Change

  • Bug fix
  • New feature
  • Documentation update
  • Release
  • Refactor
  • Other (please describe):

Testing

Tested by running locally

Screenshots (if applicable)

Screenshot from 2025-04-18 00-22-23


Important

Added overflow option to StyleGroup in group.ts with options visible, hidden, scroll, auto.

  • New Feature:
    • Added overflow option to StyleGroup in group.ts.
    • Supports options: visible, hidden, scroll, auto.

This description was created by Ellipsis for c8cbf2b. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to c8cbf2b in 2 minutes and 7 seconds

More details
  • Looked at 14 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. apps/studio/src/lib/editor/styles/group.ts:174
  • Draft comment:
    The overflow options are missing the 'clip' option as described in the issue requirements.
  • Reason this comment was not posted:
    Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 20% vs. threshold = 50%
    Without seeing the referenced issue requirements, I can't verify if 'clip' is actually required. The current options match the standard CSS overflow values. 'clip' is a less common value and while valid in some contexts, I can't be certain it's needed here. The comment relies on external context I don't have.
    I might be too quick to dismiss the comment - 'clip' is a valid CSS overflow value that could be legitimately required by the project.
    However, per the review rules, I need STRONG EVIDENCE that the comment is correct. Without access to the issue requirements, I can't verify this suggestion.
    The comment should be removed since it relies on external context (issue requirements) that I can't verify.
2. apps/studio/src/lib/editor/styles/group.ts:174
  • Draft comment:
    Consider including the 'clip' option. The issue description lists five options (visible, hidden, clip, scroll, auto) and suggests choosing clip over hidden for clarity. Adjust the options accordingly.
  • Reason this comment was not posted:
    Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 10% vs. threshold = 50%
    The comment references an "issue description" but we don't have access to that. The standard CSS overflow property typically uses visible/hidden/scroll/auto, and 'clip' is a less common value. Without seeing the issue description they're referring to, we can't verify if this suggestion is valid. The current options list matches standard CSS overflow values.
    I might be missing important context from the issue description that would justify adding 'clip'. The comment seems to reference specific requirements I can't see.
    Without access to the referenced issue description or requirements, I cannot verify if 'clip' is actually needed. The current implementation uses standard CSS overflow values.
    Delete the comment since we can't verify its correctness without the referenced issue description, and the current implementation uses standard CSS overflow values.

Workflow ID: wflow_2qRPuZkkoYqfwVgi


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@Kitenite Kitenite merged commit ccbfb96 into onlook-dev:main Apr 20, 2025
@Kitenite
Copy link
Contributor

Nice thanks Abu!

ml-delaurier pushed a commit to ml-delaurier/nolook that referenced this pull request Apr 23, 2025
zongkelong pushed a commit to zongkelong/coolook that referenced this pull request Apr 25, 2025
* 'main' of https://github.com/onlook-dev/onlook:
  use DomElementStyles (onlook-dev#1810)
  feat: Added file watcher & auto update modified opened files in Dev Tab (onlook-dev#1802)
  fix: border thickness hidden when setting border color from color picker (onlook-dev#1805)
  move overflow input (onlook-dev#1800)
  Added overflow option in the style panel (onlook-dev#1793)
  refactor: update images manager (onlook-dev#1784)
  chore: error nesting button (onlook-dev#1790)
  refactor: update naming for brand color (onlook-dev#1785)
  Tys toolbar v4 (onlook-dev#1786)
t1c1 pushed a commit to t1c1/onlookbotcodes that referenced this pull request Jun 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feat] Overflow options
2 participants