Skip to content

move overflow input #1800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 20, 2025
Merged

move overflow input #1800

merged 1 commit into from
Apr 20, 2025

Conversation

Kitenite
Copy link
Contributor

@Kitenite Kitenite commented Apr 20, 2025

Description

Related Issues

Type of Change

  • Bug fix
  • New feature
  • Documentation update
  • Release
  • Refactor
  • Other (please describe):

Testing

Screenshots (if applicable)

Additional Notes


Important

Refactor group.ts by moving overflow style within StyleGroup for better organization.

  • Refactor:
    • Move overflow style definition within StyleGroup in group.ts for better organization.

This description was created by Ellipsis for e571019. You can customize this summary. It will automatically update as commits are pushed.

@Kitenite Kitenite merged commit daedd2f into main Apr 20, 2025
@Kitenite Kitenite deleted the feat/move-overflw branch April 20, 2025 01:34
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to e571019 in 1 minute and 18 seconds. Click for details.
  • Reviewed 24 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 5 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. apps/studio/src/lib/editor/styles/group.ts:171
  • Draft comment:
    Overflow input removed from here; ensure the new ordering in StyleGroup (moved to bottom) is intentional and doesn’t affect the UI order.
  • Reason this comment was not posted:
    Comment looked like it was already resolved.
2. apps/studio/src/lib/editor/styles/group.ts:239
  • Draft comment:
    Overflow style added here; confirm this placement is as intended for styling precedence.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% The comment is asking the PR author to confirm their intention regarding the placement of the overflow style. This violates the rule against asking the author to confirm their intention or ensure behavior is intended.
3. apps/studio/src/lib/editor/styles/group.ts:171
  • Draft comment:
    PR description mentions onboarding docs, yet this diff only moves the overflow input. Please update the PR description to accurately reflect the changes.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% This comment is asking the PR author to update the PR description, which is against the rules provided. The comment does not provide a specific code suggestion or ask for a test to be written. Therefore, it should be removed.
4. apps/studio/src/lib/editor/styles/group.ts:242
  • Draft comment:
    Overflow input was repositioned from the top of StyleGroup to its end. Ensure this reordering is intentional and that the UI grouping isn’t adversely affected.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50% None
5. apps/studio/src/lib/editor/styles/group.ts:244
  • Draft comment:
    The PR description indicates onboarding docs improvements (issue 123), but no documentation changes are shown. Please update the PR to include the necessary docs updates if intended.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% This comment is asking the PR author to update the PR description and ensure documentation changes are included, which violates the rules. It doesn't provide a specific code suggestion or ask for a specific test to be written.

Workflow ID: wflow_d840rZxlSPlfqPOq

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

ml-delaurier pushed a commit to ml-delaurier/nolook that referenced this pull request Apr 23, 2025
zongkelong pushed a commit to zongkelong/coolook that referenced this pull request Apr 25, 2025
* 'main' of https://github.com/onlook-dev/onlook:
  use DomElementStyles (onlook-dev#1810)
  feat: Added file watcher & auto update modified opened files in Dev Tab (onlook-dev#1802)
  fix: border thickness hidden when setting border color from color picker (onlook-dev#1805)
  move overflow input (onlook-dev#1800)
  Added overflow option in the style panel (onlook-dev#1793)
  refactor: update images manager (onlook-dev#1784)
  chore: error nesting button (onlook-dev#1790)
  refactor: update naming for brand color (onlook-dev#1785)
  Tys toolbar v4 (onlook-dev#1786)
t1c1 pushed a commit to t1c1/onlookbotcodes that referenced this pull request Jun 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant