Skip to content

docs(sdk-metrics): fix typos and add missing parameter docs#3244

Merged
pichlermarc merged 6 commits intoopen-telemetry:mainfrom
dynatrace-oss-contrib:docs/sdk-metrics
Sep 13, 2022
Merged

docs(sdk-metrics): fix typos and add missing parameter docs#3244
pichlermarc merged 6 commits intoopen-telemetry:mainfrom
dynatrace-oss-contrib:docs/sdk-metrics

Conversation

@pichlermarc
Copy link
Copy Markdown
Member

Which problem is this PR solving?

Spotted some typos and missing parameter docs in the metrics SDK package. This PR addresses them. 🙂

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • This change requires a documentation update

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added
  • Documentation has been updated

@pichlermarc pichlermarc marked this pull request as ready for review September 9, 2022 09:56
@pichlermarc pichlermarc requested a review from a team September 9, 2022 09:56
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 9, 2022

Codecov Report

Merging #3244 (2c9777a) into main (032f68f) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3244   +/-   ##
=======================================
  Coverage   93.29%   93.29%           
=======================================
  Files         203      203           
  Lines        6606     6606           
  Branches     1389     1389           
=======================================
  Hits         6163     6163           
  Misses        443      443           
Impacted Files Coverage Δ
.../opentelemetry-sdk-metrics/src/aggregator/types.ts 100.00% <ø> (ø)
...elemetry-sdk-metrics/src/state/MeterSharedState.ts 96.15% <ø> (ø)
...y-sdk-metrics/src/state/TemporalMetricProcessor.ts 98.21% <ø> (ø)
...es/opentelemetry-sdk-metrics/src/view/Predicate.ts 100.00% <ø> (ø)

@pichlermarc pichlermarc changed the title docs(sdk-metrics): fix typos and add missing parameter docs. docs(sdk-metrics): fix typos and add missing parameter docs Sep 9, 2022
@legendecas legendecas added the sdk:metrics Issues and PRs related to the Metrics SDK label Sep 13, 2022
@pichlermarc pichlermarc merged commit bd0a77f into open-telemetry:main Sep 13, 2022
@pichlermarc pichlermarc deleted the docs/sdk-metrics branch September 13, 2022 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

sdk:metrics Issues and PRs related to the Metrics SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants