feat(exporter-prometheus): support withoutScopeInfo option#5993
feat(exporter-prometheus): support withoutScopeInfo option#5993pichlermarc merged 2 commits intoopen-telemetry:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5993 +/- ##
==========================================
- Coverage 95.16% 95.16% -0.01%
==========================================
Files 316 316
Lines 9207 9220 +13
Branches 2075 2080 +5
==========================================
+ Hits 8762 8774 +12
- Misses 445 446 +1
🚀 New features to boost your workflow:
|
3ce69fd to
cf601e8
Compare
|
@pichlermarc would you mind taking a look? |
|
The Windows test failure appears to be a flake - #6042 |
|
Maybe @david-luna could take a look? |
|
@cjihrig Are you able to provide some background for a reviewer that might not be so familiar with Prometheus, or exactly what references you mean by "from the spec.". I clicked through to open-telemetry/opentelemetry-specification#4223 (comment) but am not sure if that is the best reference here. |
|
Sure @trentm. I was looking at this page. Apologies if that shouldn't be referred to as the spec, but I assumed it was based on the "specs" in the URL. From that page, I was referring to:
I changed the name from snake_case to camelCase to match the other options used in the JS repo. Looking at the test data from the Golang repo, you can see examples like this one (or most of the other examples in that directory). Note the |
pichlermarc
left a comment
There was a problem hiding this comment.
sorry for the delay on this PR - looks good overall, just one question.
This commit adds support for the without_scope_info option (converted to camelCase to match other options) from the spec.
fefeeb7 to
fcb2aa0
Compare
Which problem is this PR solving?
This commit adds support for the
without_scope_infooption (converted to camelCase to match other options) from the spec.Fixes # N/A
Related: Here are some output snapshots from the Golang library which include the scope labels.
Type of change
How Has This Been Tested?
Checklist: