Skip to content

test(otlp-grpc-exporter-base): increase timeout in flaky test#6042

Merged
pichlermarc merged 2 commits intoopen-telemetry:mainfrom
cjihrig:flake
Oct 24, 2025
Merged

test(otlp-grpc-exporter-base): increase timeout in flaky test#6042
pichlermarc merged 2 commits intoopen-telemetry:mainfrom
cjihrig:flake

Conversation

@cjihrig
Copy link
Copy Markdown
Contributor

@cjihrig cjihrig commented Oct 24, 2025

Which problem is this PR solving?

A 100ms timeout leads to flaky test failures on slow operating systems running on slow CI machines.

Fixes # https://github.com/open-telemetry/opentelemetry-js/actions/runs/18766046670/job/53541209988

Short description of the changes

This commit increases the timeout substantially so it should no longer be an issue. The timeout itself does not appear to be part of any test functionality, as Mocha is not reporting any additional slow tests because of the change.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Reproduced the CI issue locally by reducing the timeout duration.
  • Increased the timeout and verified that all tests passed again without any additional delays in the tests.

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added
  • Documentation has been updated

@cjihrig cjihrig requested a review from a team as a code owner October 24, 2025 01:52
Comment thread experimental/CHANGELOG.md Outdated
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.14%. Comparing base (7e0d45f) to head (f8009cb).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6042   +/-   ##
=======================================
  Coverage   95.14%   95.14%           
=======================================
  Files         315      315           
  Lines        9161     9161           
  Branches     2022     2022           
=======================================
  Hits         8716     8716           
  Misses        445      445           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@pichlermarc pichlermarc added this pull request to the merge queue Oct 24, 2025
Merged via the queue into open-telemetry:main with commit e6620ed Oct 24, 2025
27 checks passed
@otelbot
Copy link
Copy Markdown
Contributor

otelbot Bot commented Oct 24, 2025

Thank you for your contribution @cjihrig! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey.

@cjihrig cjihrig deleted the flake branch October 24, 2025 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants