Skip to content

feat: add hosted mcp tool support #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Conversation

yusuf-eren
Copy link

No description provided.

Copy link

changeset-bot bot commented Jun 5, 2025

⚠️ No Changeset found

Latest commit: 75404f0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Collaborator

@dkundel-openai dkundel-openai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing this! Since we have an approval flow for local function tool calls already, can you make this work with result.interruptions? https://openai.github.io/openai-agents-js/guides/human-in-the-loop/

This will likely require:

  1. Changing the logic in runImplementation.ts to detect if a hosted MCP tool has requested approval and trigger an interruption with an approval item
  2. Change the approve and reject functions to create the respective items for an approval.
  3. Make sure that in run the run continues appropriately.

Adding @seratch here who had been looking into this as well.

output: process.stdout,
});

function approvalCallback(toolName: string): Promise<boolean> {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think I understand how this is currently being used

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants