Skip to content

Conversation

@eme64
Copy link
Contributor

@eme64 eme64 commented Dec 2, 2024

This is the string based version.

Here another more "functional" version, which has better type checking: #23418

TODO is rework of #22358

Previous work: #22715 and #22716


TODO

  • Readme

  • Simple tests for basic functionality -> string compare!

  • Extend library

    • Delay constant folding - boolean or int?
    • Generate ranges
    • State class: could trigger state change for every test invocation?
  • constants:

    • Use Generators!
  • Easy generation of programmatic CodeGenerator

    • improve API for recursive calls, parameter checks/load, etc

Tests:

  • IR test
  • random distribution tests: need Verify and Generators!


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8344942: Template-Based Testing Framework (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22483/head:pull/22483
$ git checkout pull/22483

Update a local copy of the PR:
$ git checkout pull/22483
$ git pull https://git.openjdk.org/jdk.git pull/22483/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22483

View PR using the GUI difftool:
$ git pr show -t 22483

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22483.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 2, 2024

👋 Welcome back epeter! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 2, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title JDK-8344942 8344942: Template-Based Testing Framework Dec 2, 2024
@openjdk
Copy link

openjdk bot commented Dec 2, 2024

@eme64 The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 27, 2025

@eme64 This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@eme64 eme64 mentioned this pull request Feb 3, 2025
3 tasks
@bridgekeeper
Copy link

bridgekeeper bot commented Mar 24, 2025

@eme64 This pull request has been inactive for more than 16 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

1 participant