Skip to content

8352861: Template-Framework Library #23418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 214 commits into from

Conversation

eme64
Copy link
Contributor

@eme64 eme64 commented Feb 3, 2025

Template Library in progress.

Please review the Template Framework PR: #24217

TODO new path like openjdk/skara#1709

Previous version of Template Framework: #22483


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8352861: Template-Framework Library (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23418/head:pull/23418
$ git checkout pull/23418

Update a local copy of the PR:
$ git checkout pull/23418
$ git pull https://git.openjdk.org/jdk.git pull/23418/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23418

View PR using the GUI difftool:
$ git pr show -t 23418

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23418.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 3, 2025

👋 Welcome back epeter! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Feb 3, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title JDK-8344942 8344942: Template-Based Testing Framework Feb 3, 2025
@openjdk
Copy link

openjdk bot commented Feb 3, 2025

@eme64 The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk
Copy link

openjdk bot commented Mar 20, 2025

@eme64 this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout JDK-8344942-TemplateFramework-v2
git fetch https://git.openjdk.org/jdk.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk openjdk bot added the merge-conflict Pull request has merge conflict with target branch label Mar 20, 2025
@openjdk openjdk bot removed the merge-conflict Pull request has merge conflict with target branch label Mar 25, 2025
@eme64 eme64 changed the title 8344942: Template-Based Testing Framework 8352861: Template-Framework Library Mar 25, 2025
@bridgekeeper
Copy link

bridgekeeper bot commented Apr 9, 2025

@eme64 This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 4, 2025

@eme64 This pull request has been inactive for more than 16 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant