Conversation
🦋 Changeset detectedLatest commit: 40fca1c The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
conico974
left a comment
There was a problem hiding this comment.
LGTM.
It should probably be in a minor release though, a big warning in the release note about the breaking change for custom wrapper should be enough.
We'll need to update the docs as well
Thanks for the review. I'll polish the code, add a BREAKING CHANGE changeset, and prepare a doc PR before this is released. |
waitUntil passed around via ALS
a32d5fc to
ea04483
Compare
|
@conico974 added a commit to polish the code and add a changeset, PTAL |
conico974
left a comment
There was a problem hiding this comment.
If you could just fix the biome linting issue and see my 2 little comments, other than that LGTM
Co-authored-by: conico974 <nicodorseuil@yahoo.fr>
|
Thanks for the review @conico974, I have addressed the comment. |
@conico974 this a POC to fix #713
I tested locally that
waitUntilis available for middleware and the serverwaitUntilis fixed when there is a nested request inside a long running requestThe handler API is changed so this is a breaking change.
What do you think?