un-skip the ssr loading e2e test in the app-router app

[dario-piotrowicz]

I'm pretty sure I was getting this test failing both locally and in CI, but now everything seems to be working just fine... 🤔

---

fixes #313

[changeset-bot]

⚠️ No Changeset found

Latest commit: 01c1e6b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[pkg-pr-new]

Open in Stackblitz

pnpm add https://pkg.pr.new/@opennextjs/cloudflare@406

commit: 01c1e6b

[dario-piotrowicz]

@conico974 any idea if something in the aws package fixed this?

In that case this comment might no longer be valid?

opennextjs-cloudflare/examples/e2e/app-router/e2e/ssr.test.ts

Lines 1 to 2 in db8969b

	// NOTE: loading.tsx is currently broken on open - next
	// This works locally but not on deployed apps

[conico974]

Not sure, maybe this one opennextjs/opennextjs-aws#733, or this one opennextjs/opennextjs-aws#718
That's the only 2 i can imagine having any effect

[dario-piotrowicz]

Not sure, maybe this one opennextjs/opennextjs-aws#733, or this one opennextjs/opennextjs-aws#718 That's the only 2 i can imagine having any effect

given the comment I would assume that these tests are skipped during the aws ci e2es, but by looking at the aws code I couldn't see anything that would cause them to be skipped, could you double check if these e2e tests do run (and pass) in the aws e2es? (if so the comment would simply be outdated and no longer valid right?)

[conico974]

Ho yeah that's an old comment that can be safely removed. There was an issue with lambda streaming itself, but now it is fixed and working correctly in e2e

[dario-piotrowicz]

Ho yeah that's an old comment that can be safely removed. There was an issue with lambda streaming itself, but now it is fixed and working correctly in e2e

ah ok nice! I've removed the comment here then and opened a PR in the aws repo to remove them there too: opennextjs/opennextjs-aws#751 🙂