fix: regression where getEnvFromPlatformProxy received wrong options type#1206
Merged
james-elicx merged 3 commits intoopennextjs:mainfrom Apr 17, 2026
Merged
Conversation
🦋 Changeset detectedLatest commit: c731edb The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
…type This fixes a regression introduced in opennextjs@32ba91a where `getEnvFromPlatformProxy` call sites passed `OpenNextConfig` even though the function expects Wrangler `GetPlatformProxyOptions`. The fix restores the pre-32ba91a argument shape by passing `{ configPath, environment }` from CLI arguments, so env resolution follows the selected Wrangler config/environment. It also adds explicit return type annotations to related CLI helpers to make declaration output stable and not rely on inference.
bbc28dc to
ea8c543
Compare
james-elicx
reviewed
Apr 17, 2026
james-elicx
approved these changes
Apr 17, 2026
Collaborator
james-elicx
left a comment
There was a problem hiding this comment.
Thanks for the PR.
I just pushed a commit to remove some of the return type changes for the internal utils so that the PR is scoped to the fix and can be merged without any nitpicks about types. Hope that's okay :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a regression introduced in 32ba91a where
getEnvFromPlatformProxycall sites passedOpenNextConfigeven though the function expects WranglerGetPlatformProxyOptions.The fix restores the pre-32ba91a argument shape by passing
{ configPath, environment }from CLI arguments, so env resolution follows the selected Wrangler config/environment.It also adds explicit return type annotations to related CLI helpers to make declaration output stable and not rely on inference.