Skip to content

fix: regression where getEnvFromPlatformProxy received wrong options type #1206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
james-elicx merged 3 commits into from
Apr 17, 2026
+30 −3
Merged

fix: regression where getEnvFromPlatformProxy received wrong options type #1206

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ea8c543
fix: regression where getEnvFromPlatformProxy received wrong options …
314systems Apr 16, 2026
5e91310
undo unrelated type changes
james-elicx Apr 17, 2026
c731edb
Apply suggestion from @james-elicx
james-elicx Apr 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions .changeset/red-yaks-go.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
---
"@opennextjs/cloudflare": patch
---

fix: regression where getEnvFromPlatformProxy received wrong options type

This fixes a regression introduced in [32ba91a](https://github.com/opennextjs/opennextjs-cloudflare/commit/32ba91a6d3fa6b9a8b2cd5a8c973c3b3eb1108f0) where `getEnvFromPlatformProxy` call sites passed `OpenNextConfig` even though the function expects Wrangler `GetPlatformProxyOptions`.

The fix restores the pre-[32ba91a](https://github.com/opennextjs/opennextjs-cloudflare/commit/32ba91a6d3fa6b9a8b2cd5a8c973c3b3eb1108f0) argument shape by passing `{ configPath, environment }` from CLI arguments, so env resolution follows the selected Wrangler config/environment.

It also adds explicit return type annotations to related CLI helpers to make declaration output stable and not rely on inference.
Comment thread
james-elicx marked this conversation as resolved.
Outdated
8 changes: 7 additions & 1 deletion packages/cloudflare/src/cli/commands/deploy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,13 @@ export async function deployCommand(args: WithWranglerArgs<{ cacheChunkSize?: nu

const wranglerConfig = await readWranglerConfig(args);

const envVars = await getEnvFromPlatformProxy(config, buildOpts);
const envVars = await getEnvFromPlatformProxy(
{
configPath: args.wranglerConfigPath,
environment: args.env,
},
buildOpts
);

await populateCache(
buildOpts,
Expand Down
8 changes: 7 additions & 1 deletion packages/cloudflare/src/cli/commands/populate-cache.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,13 @@ async function populateCacheCommand(
const buildOpts = getNormalizedOptions(config);

const wranglerConfig = await readWranglerConfig(args);
const envVars = await getEnvFromPlatformProxy(config, buildOpts);
const envVars = await getEnvFromPlatformProxy(
{
configPath: args.wranglerConfigPath,
environment: args.env,
},
buildOpts
);

await populateCache(
buildOpts,
Expand Down
8 changes: 7 additions & 1 deletion packages/cloudflare/src/cli/commands/preview.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,13 @@ export async function previewCommand(
const buildOpts = getNormalizedOptions(config);

const wranglerConfig = await readWranglerConfig(args);
const envVars = await getEnvFromPlatformProxy(config, buildOpts);
const envVars = await getEnvFromPlatformProxy(
{
configPath: args.wranglerConfigPath,
environment: args.env,
},
buildOpts
);

await populateCache(
buildOpts,
Expand Down
Loading