ReplaceStringBuilderWithString should keep newlines

[Jammy-Louie]

What's changed?

ReplaceStringBuilderWithString will retain the prefix white space for the removed method calls on the argument.

What's your motivation?

• fixes ReplaceStringBuilderWithString should keep newlines #88

Anything in particular you'd like reviewers to focus on?

Anyone you would like to review specifically?

Have you considered any alternatives or workarounds?

Any additional context

Checklist

• I've added unit tests to cover both positive and negative cases
• I've read and applied the recipe conventions and best practices
• I've used the IntelliJ IDEA auto-formatter on affected files

[Laurens-W]

I can't help but wonder if registering a maybeAutoFormat would be preferred here instead of manually messing with the spacing

[github-actions]

Some suggestions could not be made:

• src/main/java/org/openrewrite/staticanalysis/ReplaceStringBuilderWithString.java
  • lines 32-32

[timtebeek]

Nice improvement already! I suggest we merge this once the forced pushed issues are resolved.

Separately after we could look into supporting comments as well, as this right now fails.

    @Test
    @Issue("https://github.com/openrewrite/rewrite-static-analysis/issues/88")
    void retainComments() {
        rewriteRun(
          //language=java
          java(
            """
              class A {
                  void foo() {
                      String scenarioFour = new StringBuilder()
                          // A
                          .append("A")
                          // B
                          .append("B")
                          // C
                          .append("C")
                          .toString();
                  }
              }
              """,
            """
              class A {
                  void foo() {
                      String scenarioFour =
                          // A
                          "A" +
                          // B
                          "B" +
                          // C
                          "C" +
                          testString();
                  }
              }
              """
          )
        );
    }