-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Add tracking for long running SearchTask post cancellation #17726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tracking for long running SearchTask post cancellation #17726
Conversation
d739404
to
ea4d4da
Compare
❌ Gradle check result for ea4d4da: Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
server/src/main/java/org/opensearch/tasks/TaskCancellationStats.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/tasks/TaskCancellationStats.java
Outdated
Show resolved
Hide resolved
ea4d4da
to
c940580
Compare
❌ Gradle check result for c940580: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Ruirui Zhang <[email protected]>
Signed-off-by: Ruirui Zhang <[email protected]>
c940580
to
5d0ecd3
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17726 +/- ##
=========================================
Coverage 72.32% 72.32%
+ Complexity 66005 65969 -36
=========================================
Files 5356 5360 +4
Lines 306446 306504 +58
Branches 44395 44405 +10
=========================================
+ Hits 221634 221685 +51
- Misses 66660 66671 +11
+ Partials 18152 18148 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-17726-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 e9d8e0007b58f96a89b1a400a14eb2ed9f7aa597
# Push it to GitHub
git push --set-upstream origin backport/backport-17726-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x Then, create a pull request where the |
…h-project#17726) Signed-off-by: Ruirui Zhang <[email protected]> * add tracking for long running SearchTask post cancellation Signed-off-by: Ruirui Zhang <[email protected]> * add version checks for searchTask Signed-off-by: Ruirui Zhang <[email protected]> (cherry picked from commit e9d8e00)
Description
This PR addes tracking logic for SearchTask to monitor rogue queries at the coordinator level. Previously, the service only tracked SearchShardTask (queries at the shard level) that were cancelled but continued running.
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
#17719
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.