Skip to content

[Backport 2.x] Add tracking for long running SearchTask post cancellation #18021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

ruai0511
Copy link
Contributor

Description

Backport #17726

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…h-project#17726)

Signed-off-by: Ruirui Zhang <[email protected]>

* add tracking for long running SearchTask post cancellation
Signed-off-by: Ruirui Zhang <[email protected]>

* add version checks for searchTask
Signed-off-by: Ruirui Zhang <[email protected]>
(cherry picked from commit e9d8e00)
@jainankitk
Copy link
Contributor

@ruai0511 - Build is failing because of missing 3_0 version in 2.x branch:

 /home/runner/work/OpenSearch/OpenSearch/server/src/main/java/org/opensearch/tasks/TaskCancellationStats.java:38: error: cannot find symbol
        if (in.getVersion().onOrAfter(Version.V_3_0_0)) {
                                             ^
  symbol:   variable V_3_0_0
  location: class Version
/home/runner/work/OpenSearch/OpenSearch/server/src/main/java/org/opensearch/tasks/TaskCancellationStats.java:66: error: cannot find symbol
        if (out.getVersion().onOrAfter(Version.V_3_0_0)) {
                                              ^
  symbol:   variable V_3_0_0
  location: class Version
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
2 errors

> Task :server:compileJava FAILED

Copy link
Contributor

❌ Gradle check result for d113e83: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@andrross
Copy link
Member

@ruai0511 No more releases are planned from the 2.x branch. Do we need this backport?

@ruai0511
Copy link
Contributor Author

Closing this as the feature is not needed to backport to 2.x

@ruai0511 ruai0511 closed this Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants