Skip to content

Remove Reader Writer Split experimental feature flag #17880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Apr 15, 2025
Merged

Remove Reader Writer Split experimental feature flag #17880

merged 13 commits into from
Apr 15, 2025

Conversation

vinaykpud
Copy link
Contributor

Description

Removed RW Split experimental feature flag

Related Issues

Related #15306

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@vinaykpud vinaykpud marked this pull request as ready for review April 10, 2025 16:12
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 202f30c: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@vinaykpud
Fixed failing tests
c86136d 
Signed-off-by: Vinay Krishna Pudyodu <[email protected]>
@vinaykpud
Merge branch 'main' into rw/removefeatureflag-1
9e2b726 
Signed-off-by: Vinay Krishna Pudyodu <[email protected]>
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 9e2b726: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@vinaykpud vinaykpud reopened this Apr 12, 2025
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 25cf1ff: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

This was referenced Apr 14, 2025
Open
Open
Open
Open
Open
Open
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 25cf1ff: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 4481794: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 4481794: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

This was referenced Apr 15, 2025
Closed
Closed
Open
Open
@vinaykpud
Revert "Fixed failing unit tests"
25c97de 
This reverts commit 7aa103a.

Signed-off-by: Vinay Krishna Pudyodu <[email protected]>
@vinaykpud
Revert "Fixed the way roles added while creating node for testing"
e05be47 
This reverts commit 4481794.

Signed-off-by: Vinay Krishna Pudyodu <[email protected]>
@vinaykpud
Added SEARCH_ROLE to rolesToMap
d46f9a4 
Signed-off-by: Vinay Krishna Pudyodu <[email protected]>
@vinaykpud
Merge branch 'main' into rw/removefeatureflag-1
6bfe0a0 
Signed-off-by: Vinay Krishna Pudyodu <[email protected]>
@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for 6bfe0a0: SUCCESS

@codecov Codecov
Copy link

codecov bot commented Apr 15, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 92.30769% with 1 line in your changes missing coverage. Please review.

Project coverage is 72.47%. Comparing base (471acef) to head (6bfe0a0).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
...g/opensearch/cluster/routing/OperationRouting.java 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main   #17880      +/-   ##
============================================
- Coverage     72.52%   72.47%   -0.05%     
+ Complexity    67031    67005      -26     
============================================
  Files          5470     5470              
  Lines        309707   309697      -10     
  Branches      45052    45045       -7     
============================================
- Hits         224617   224459     -158     
- Misses        66774    66917     +143     
- Partials      18316    18321       +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mch2 mch2 merged commit 5799fe7 into opensearch-project:main Apr 15, 2025
34 of 36 checks passed
@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Apr 30, 2025
Closed
Harsh-87 pushed a commit to Harsh-87/OpenSearch that referenced this pull request May 7, 2025
@vinaykpud
Remove Reader Writer Split experimental feature flag (opensearch-proj…
1b9fb34 
…ect#17880)

* Remove Reader Writer Split experimental feature flag

Signed-off-by: Vinay Krishna Pudyodu <[email protected]>

* Fixed failing tests

Signed-off-by: Vinay Krishna Pudyodu <[email protected]>

* Fixed failing unit tests

Signed-off-by: Vinay Krishna Pudyodu <[email protected]>

* Added back setting updater in Search only Operation routing

Signed-off-by: Vinay Krishna Pudyodu <[email protected]>

* Fixed SpotlessApply

Signed-off-by: Vinay Krishna Pudyodu <[email protected]>

* Fixed the way roles added while creating node for testing

Signed-off-by: Vinay Krishna Pudyodu <[email protected]>

* Revert "Fixed failing unit tests"

This reverts commit 7aa103a.

Signed-off-by: Vinay Krishna Pudyodu <[email protected]>

* Revert "Fixed the way roles added while creating node for testing"

This reverts commit 4481794.

Signed-off-by: Vinay Krishna Pudyodu <[email protected]>

* Added SEARCH_ROLE to rolesToMap

Signed-off-by: Vinay Krishna Pudyodu <[email protected]>

---------

Signed-off-by: Vinay Krishna Pudyodu <[email protected]>
Signed-off-by: Harsh Kothari <[email protected]>
Harsh-87 pushed a commit to Harsh-87/OpenSearch that referenced this pull request May 7, 2025
@vinaykpud
Remove Reader Writer Split experimental feature flag (opensearch-proj…
4b75339 
…ect#17880)

* Remove Reader Writer Split experimental feature flag

Signed-off-by: Vinay Krishna Pudyodu <[email protected]>

* Fixed failing tests

Signed-off-by: Vinay Krishna Pudyodu <[email protected]>

* Fixed failing unit tests

Signed-off-by: Vinay Krishna Pudyodu <[email protected]>

* Added back setting updater in Search only Operation routing

Signed-off-by: Vinay Krishna Pudyodu <[email protected]>

* Fixed SpotlessApply

Signed-off-by: Vinay Krishna Pudyodu <[email protected]>

* Fixed the way roles added while creating node for testing

Signed-off-by: Vinay Krishna Pudyodu <[email protected]>

* Revert "Fixed failing unit tests"

This reverts commit 7aa103a.

Signed-off-by: Vinay Krishna Pudyodu <[email protected]>

* Revert "Fixed the way roles added while creating node for testing"

This reverts commit 4481794.

Signed-off-by: Vinay Krishna Pudyodu <[email protected]>

* Added SEARCH_ROLE to rolesToMap

Signed-off-by: Vinay Krishna Pudyodu <[email protected]>

---------

Signed-off-by: Vinay Krishna Pudyodu <[email protected]>
Signed-off-by: Harsh Kothari <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mch2 mch2 mch2 approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@ashking94 ashking94 Awaiting requested review from ashking94 ashking94 is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@cwperks cwperks Awaiting requested review from cwperks cwperks is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@jed326 jed326 Awaiting requested review from jed326 jed326 is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

@bugmakerrrrrr bugmakerrrrrr Awaiting requested review from bugmakerrrrrr

@jainankitk jainankitk Awaiting requested review from jainankitk

@linuxpi linuxpi Awaiting requested review from linuxpi

Assignees
No one assigned
Labels
skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vinaykpud @mch2 @prudhvigodithi