CONSOLE-4074: Address tech debt in UploadConfigSubform component

[nitin-dhevar]

No description provided.

[openshift-ci-robot]

@nitin-dhevar: This pull request references CONSOLE-4074 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[nitin-dhevar]

/hold

Depends on #14052

[nitin-dhevar]

/label tide/merge-method-squash

[nitin-dhevar]

/assign @TheRealJon

[TheRealJon]

Just a couple of tweaks

[TheRealJon]

Descriptive naming

Suggested change

	stringData,
	pullSecretData,

[TheRealJon]

This is a controlled component, so we shouldn't need state:

Suggested change

	const [configFile, setConfigFile] = React.useState<string>(
	_.isEmpty(stringData) ? '' : JSON.stringify(stringData),
	);
	const configFile = React.useMemo<string>(() =>
	pullSecretData ? JSON.stringify(pullSecretData) : '',
	[pullSecretData],
	);

[TheRealJon]

Prefer determinate try/catch rather than _.attempt:

Suggested change

	const parsedData = _.attempt(JSON.parse, fileData);
	setConfigFile(fileData);
	setParseError(_.isError(parsedData));
	onChange(parsedData);
	onDisable(_.isError(parsedData));
	try {
	const newPullSecret = JSON.parse(fileData);
	onChange(newPullSecret);
	setParseError(false);
	onDisable(false);
	} catch (e) {
	setParseError(true);
	onDisable(true);
	}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nitin-dhevar
Once this PR has been reviewed and has the lgtm label, please ask for approval from therealjon. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• frontend/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-merge-robot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci]

@nitin-dhevar: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/backend	a8c5e01	link	true	/test backend
ci/prow/analyze	a8c5e01	link	true	/test analyze
ci/prow/frontend	a8c5e01	link	true	/test frontend
ci/prow/images	a8c5e01	link	true	/test images
ci/prow/e2e-gcp-console	a8c5e01	link	true	/test e2e-gcp-console

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.