CONSOLE-4075: Address tech debt in WebHookSecretForm component #14065

nitin-dhevar · 2024-07-15T16:13:19Z

No description provided.

This reverts commit 548d7323e9ce9c4bfb4137d38e0a9342829b8fd3.

openshift-ci-robot · 2024-07-15T16:13:44Z

@nitin-dhevar: This pull request references CONSOLE-4075 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

nitin-dhevar · 2024-07-15T16:47:39Z

/hold

Depends on #14064

nitin-dhevar · 2024-07-15T16:47:47Z

/label tide/merge-method-squash

nitin-dhevar · 2024-07-15T16:48:00Z

/assign @TheRealJon

openshift-ci · 2024-07-15T18:49:35Z

@nitin-dhevar: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-gcp-console	`32e87e6`	link	true	`/test e2e-gcp-console`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

TheRealJon

Just a couple of nits.

TheRealJon · 2024-07-17T13:59:41Z

frontend/public/components/secrets/create-secret/WebHookSecretForm.tsx

-  stringData: {
-    [key: string]: string;
+  const generateWebHookSecret = () => {
+    const newSecret = generateSecret();


nit, not new, generateSecret is not a descriptive name, especially in the context of of form that is creating/editing a k8s Secret resource. This function is essentially just a random string generator, and probably isn't even necessary. We probably have a dependency that can do this for us.

TheRealJon · 2024-07-17T14:28:16Z

frontend/public/components/secrets/create-secret/WebHookSecretForm.tsx

+  const changeWebHookSecretkey = (event: React.ChangeEvent<HTMLInputElement>) => {
+    const newSecret = event.target.value;
+    onChange({ stringData: { ...stringData, WebHookSecretKey: newSecret }, base64StringData: {} });


To keep this DRY, we could separate the onChange call into it's own handler, then the text input and generator button will just pass values into it.

openshift-ci · 2024-07-17T14:35:39Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nitin-dhevar
Once this PR has been reviewed and has the lgtm label, please ask for approval from therealjon. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

frontend/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-merge-robot · 2024-07-17T14:35:47Z

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-bot · 2024-10-16T01:02:43Z

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot · 2024-11-15T08:30:41Z

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

jhadvig · 2024-11-21T15:56:59Z

Closing in favour of #14454

nitin-dhevar added 30 commits July 15, 2024 10:07

rebasing with master

01922a0

type positions fixed

40685f1

Added i18n changes

5495f36

refactoring into custom hooks for secrets title and desc

a5791c2

adding i18n changes

f8ef8bf

Revert "refactored imageSecretForm component"

3d74d9c

This reverts commit 548d7323e9ce9c4bfb4137d38e0a9342829b8fd3.

refactored ImageSecretForm component

65b1649

ImageSecretForm component file renamed

50673a5

type fixes in PullSecretForm

9edb45f

removed comments

5e380b8

adding i18n files

35fd8cd

rebase with secrets-util-refactor

cb8bc2e

adding i18n changes

fe757d6

fixing imagesecret data error

7ae84db

refactored ConfigEntryForm component

33e7ae2

Revert "refactored ConfigEntryForm component"

bcb134b

refactored ConfigEntryForm component

fd5fc1e

renamed ConfigEntryForm file

5a2a63d

refactoring into controlled component

89be65d

adding type def for updateEntry

b7a3adb

adding 18n changes

fbed05c

fixing auth param error

ac78dd2

adding auth condition

317c297

refactoring createConfigSubform component

c6dc223

fixing types

412fff4

renaming file to PullSecretCredentialsForm

c0e4cdc

adding i18n changes

a03809d

renaming component

c4b2771

renaming component

2d9d72e

Added i18n changes

540e685

nitin-dhevar added 3 commits July 15, 2024 11:32

refactoring upload config subform

79c8105

renaming uploadConfigSub form

5fac2d6

refactoring webhooksecret form

32e87e6

nitin-dhevar changed the title ~~Console 4075~~ CONSOLE-4075: Address tech debt in WebHookSecretForm component Jul 15, 2024

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 15, 2024

openshift-ci bot requested review from lokanandaprabhu and zherman0 July 15, 2024 16:13

openshift-ci bot added component/core Related to console core functionality component/pipelines Related to pipelines-plugin kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated labels Jul 15, 2024

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 15, 2024

openshift-ci bot assigned TheRealJon Jul 15, 2024

openshift-ci bot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jul 15, 2024

nitin-dhevar mentioned this pull request Jul 15, 2024

CONSOLE-4076: Address tech debt in SourceSecretForm component #14066

Closed

TheRealJon requested changes Jul 17, 2024

View reviewed changes

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 17, 2024

openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 16, 2024

openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Nov 15, 2024

jhadvig closed this Nov 21, 2024

CONSOLE-4075: Address tech debt in WebHookSecretForm component #14065

CONSOLE-4075: Address tech debt in WebHookSecretForm component #14065

Uh oh!

Conversation

nitin-dhevar commented Jul 15, 2024

Uh oh!

openshift-ci-robot commented Jul 15, 2024 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nitin-dhevar commented Jul 15, 2024

Uh oh!

nitin-dhevar commented Jul 15, 2024

Uh oh!

nitin-dhevar commented Jul 15, 2024

Uh oh!

openshift-ci bot commented Jul 15, 2024

Uh oh!

TheRealJon left a comment

Choose a reason for hiding this comment

Uh oh!

TheRealJon Jul 17, 2024

Choose a reason for hiding this comment

Uh oh!

TheRealJon Jul 17, 2024

Choose a reason for hiding this comment

Uh oh!

openshift-ci bot commented Jul 17, 2024

Uh oh!

openshift-merge-robot commented Jul 17, 2024

Uh oh!

openshift-bot commented Oct 16, 2024

Uh oh!

openshift-bot commented Nov 15, 2024

Uh oh!

jhadvig commented Nov 21, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

openshift-ci-robot commented Jul 15, 2024 •

edited by openshift-ci bot

Loading