Skip to content

CONSOLE-4076: Address tech debt in SourceSecretForm component #14066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nitin-dhevar wants to merge 38 commits into from
Closed

CONSOLE-4076: Address tech debt in SourceSecretForm component #14066

nitin-dhevar wants to merge 38 commits into from

Conversation

@nitin-dhevar
Copy link
Contributor

@nitin-dhevar nitin-dhevar commented Jul 15, 2024

No description provided.

@nitin-dhevar
rebasing with master
01922a0
@nitin-dhevar
type positions fixed
40685f1
@nitin-dhevar
Added i18n changes
5495f36
@nitin-dhevar
refactoring into custom hooks for secrets title and desc
a5791c2
@nitin-dhevar
adding i18n changes
f8ef8bf
@nitin-dhevar
Revert "refactored imageSecretForm component"
3d74d9c 
This reverts commit 548d7323e9ce9c4bfb4137d38e0a9342829b8fd3.
@nitin-dhevar
refactored ImageSecretForm component
65b1649
@nitin-dhevar
ImageSecretForm component file renamed
50673a5
@nitin-dhevar
type fixes in PullSecretForm
9edb45f
@nitin-dhevar
removed comments
5e380b8
@nitin-dhevar
adding i18n files
35fd8cd
@nitin-dhevar
rebase with secrets-util-refactor
cb8bc2e
@nitin-dhevar
adding i18n changes
fe757d6
@nitin-dhevar
fixing imagesecret data error
7ae84db
@nitin-dhevar
refactored ConfigEntryForm component
33e7ae2
@nitin-dhevar
Revert "refactored ConfigEntryForm component"
bcb134b
@nitin-dhevar
refactored ConfigEntryForm component
fd5fc1e
@nitin-dhevar
renamed ConfigEntryForm file
5a2a63d
@nitin-dhevar
refactoring into controlled component
89be65d
@nitin-dhevar
adding type def for updateEntry
b7a3adb
@nitin-dhevar
adding 18n changes
fbed05c
@nitin-dhevar
fixing auth param error
ac78dd2
@nitin-dhevar
adding auth condition
317c297
@nitin-dhevar
refactoring createConfigSubform component
c6dc223
@nitin-dhevar
fixing types
412fff4
@nitin-dhevar
renaming file to PullSecretCredentialsForm
c0e4cdc
@nitin-dhevar
adding i18n changes
a03809d
@nitin-dhevar
renaming component
c4b2771
@nitin-dhevar
renaming component
2d9d72e
@nitin-dhevar
Added i18n changes
540e685
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 15, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 15, 2024 •
edited by openshift-ci bot
Loading

@nitin-dhevar: This pull request references CONSOLE-4076 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added component/core Related to console core functionality component/pipelines Related to pipelines-plugin kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated labels Jul 15, 2024
@nitin-dhevar
Copy link
Contributor Author

nitin-dhevar commented Jul 15, 2024

/hold

Depends on #14065

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 15, 2024
@nitin-dhevar
Copy link
Contributor Author

nitin-dhevar commented Jul 15, 2024

/label tide/merge-method-squash

@nitin-dhevar
Copy link
Contributor Author

nitin-dhevar commented Jul 15, 2024

/assign @TheRealJon

@openshift-ci openshift-ci bot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jul 15, 2024
@nitin-dhevar nitin-dhevar mentioned this pull request Jul 15, 2024
Closed
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 15, 2024

@nitin-dhevar: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-console de6a248 link true /test e2e-gcp-console

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nitin-dhevar, TheRealJon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 17, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 17, 2024
@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Jul 17, 2024

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

1 similar comment
@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Jul 17, 2024

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-bot
Copy link
Contributor

openshift-bot commented Oct 16, 2024

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 16, 2024
@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 15, 2024

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Nov 15, 2024
@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 16, 2024

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-ci openshift-ci bot closed this Dec 16, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 16, 2024

@openshift-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TheRealJon TheRealJon TheRealJon approved these changes

@dtaylor113 dtaylor113 Awaiting requested review from dtaylor113

@karthikjeeyar karthikjeeyar Awaiting requested review from karthikjeeyar

Assignees

@TheRealJon TheRealJon

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/pipelines Related to pipelines-plugin do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@nitin-dhevar @openshift-ci-robot @openshift-merge-robot @openshift-bot @TheRealJon