Skip to content

OCPBUGS-53385: Fixed typo: PodDiscruptionBudget -> PodDisruptionBudget #14791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 23, 2025
Merged

OCPBUGS-53385: Fixed typo: PodDiscruptionBudget -> PodDisruptionBudget #14791

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
78c2201
Fixed typo
martin-s-a Feb 24, 2025
ec88a04
Merge branch 'openshift:main' into main
martin-s-a Mar 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion frontend/packages/console-app/locales/en/console-app.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -547,7 +547,7 @@
"Create {{label}}": "Create {{label}}",
"Edit {{label}}": "Edit {{label}}",
"{helpText}": "{helpText}",
"Create PodDiscruptionBudget": "Create PodDiscruptionBudget",
"Create PodDisruptionBudget": "Create PodDisruptionBudget",
"Disruption not allowed": "Disruption not allowed",
"PodDisruptionBudget": "PodDisruptionBudget",
"No PodDisruptionBudget": "No PodDisruptionBudget",
Expand Down
2 changes: 1 addition & 1 deletion frontend/packages/console-app/locales/es/console-app.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -529,7 +529,7 @@
"Create {{label}}": "Crear {{label}}",
"Edit {{label}}": "Editar {{label}}",
"{helpText}": "{helpText}",
"Create PodDiscruptionBudget": "Crear PodDiscruptionBudget",
Copy link
Member

@logonoff logonoff Mar 14, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

were these changes in es, fr, ja, ko, and zh done by hand, or by running yarn i18n?

Copy link
Contributor Author

@martin-s-a martin-s-a Mar 14, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They were completely manual, since I made them from GitHub's web interface without even cloning the repository.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The en locale is updated using yarn i18n, but other supported language locales are updated in the translations portal. For this type of typo error, I suggest you run yarn i18n to update the en locale, and a manual update for other locales is fine, as the word is a resource name which should be in English.
Good catch!

Copy link
Contributor Author

@martin-s-a martin-s-a Mar 15, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just tried setting up the project locally and running yarn i18n, but no files seemed to change appart from some package.json files, with apparently unrelated content. So, I guess in this specific case no further changes needed to be applied?

Note: I have basically 0 experience setting up & running openshift locally, so I might make some fairly basic mistakes, thanks for the patience.

"Create PodDisruptionBudget": "Crear PodDisruptionBudget",
"Disruption not allowed": "No se permiten interrupciones",
"PodDisruptionBudget": "PodDisruptionBudget",
"No PodDisruptionBudget": "Sin PodDisruptionBudget",
Expand Down
2 changes: 1 addition & 1 deletion frontend/packages/console-app/locales/fr/console-app.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -529,7 +529,7 @@
"Create {{label}}": "Créer {{label}}",
"Edit {{label}}": "Modifier {{label}}",
"{helpText}": "{helpText}",
"Create PodDiscruptionBudget": "Créer un objet PodDiscruptionBudget",
"Create PodDisruptionBudget": "Créer un objet PodDisruptionBudget",
"Disruption not allowed": "Disruption non autorisée",
"PodDisruptionBudget": "PodDisruptionBudget",
"No PodDisruptionBudget": "Aucun objet PodDisruptionBudget",
Expand Down
2 changes: 1 addition & 1 deletion frontend/packages/console-app/locales/ja/console-app.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -529,7 +529,7 @@
"Create {{label}}": "{{label}} の作成",
"Edit {{label}}": "{{label}} の編集",
"{helpText}": "{helpText}",
"Create PodDiscruptionBudget": "PodDiscruptionBudget の作成",
"Create PodDisruptionBudget": "PodDisruptionBudget の作成",
"Disruption not allowed": "中断できません",
"PodDisruptionBudget": "PodDisruptionBudget",
"No PodDisruptionBudget": "PodDisruptionBudget がありません",
Expand Down
2 changes: 1 addition & 1 deletion frontend/packages/console-app/locales/ko/console-app.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -529,7 +529,7 @@
"Create {{label}}": "{{label}} 만들기",
"Edit {{label}}": "{{label}} 편집",
"{helpText}": "{helpText}",
"Create PodDiscruptionBudget": "PodDiscruptionBudget 만들기",
"Create PodDisruptionBudget": "PodDisruptionBudget 만들기",
"Disruption not allowed": "중단이 허용되지 않음",
"PodDisruptionBudget": "PodDisruptionBudget",
"No PodDisruptionBudget": "PodDisruptionBudget 없음",
Expand Down
2 changes: 1 addition & 1 deletion frontend/packages/console-app/locales/zh/console-app.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -529,7 +529,7 @@
"Create {{label}}": "创建{{label}}",
"Edit {{label}}": "编辑 {{label}}",
"{helpText}": "{helpText}",
"Create PodDiscruptionBudget": "创建 PodDiscruptionBudget",
"Create PodDisruptionBudget": "创建 PodDisruptionBudget",
"Disruption not allowed": "不允许中断",
"PodDisruptionBudget": "PodDisruptionBudget",
"No PodDisruptionBudget": "没有 PodDisruptionBudget",
Expand Down
2 changes: 1 addition & 1 deletion frontend/packages/console-app/src/components/pdb/PDBPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ export const PodDisruptionBudgetsPage: React.FC<PodDisruptionBudgetsPageProps> =
<>
<ListPageHeader title={showTitle ? t(PodDisruptionBudgetModel.labelPluralKey) : undefined}>
<ListPageCreate groupVersionKind={resourceKind} createAccessReview={accessReview}>
{t('console-app~Create PodDiscruptionBudget')}
{t('console-app~Create PodDisruptionBudget')}
</ListPageCreate>
</ListPageHeader>
<ListPageBody>
Expand Down