OCPBUGS-53385: Fixed typo: PodDiscruptionBudget -> PodDisruptionBudget #14791
Conversation
openshift-ci
bot
added
needs-ok-to-test
|
Hi @MartinSalinas98. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
openshift-ci
bot
added
the
kind/i18n
|
/ok-to-test |
openshift-ci
bot
added
ok-to-test
| "Create {{label}}": "Crear {{label}}", | ||
| "Edit {{label}}": "Editar {{label}}", | ||
| "{helpText}": "{helpText}", | ||
| "Create PodDiscruptionBudget": "Crear PodDiscruptionBudget", |
There was a problem hiding this comment.
were these changes in es, fr, ja, ko, and zh done by hand, or by running yarn i18n?
There was a problem hiding this comment.
They were completely manual, since I made them from GitHub's web interface without even cloning the repository.
There was a problem hiding this comment.
The en locale is updated using yarn i18n, but other supported language locales are updated in the translations portal. For this type of typo error, I suggest you run yarn i18n to update the en locale, and a manual update for other locales is fine, as the word is a resource name which should be in English.
Good catch!
There was a problem hiding this comment.
I just tried setting up the project locally and running yarn i18n, but no files seemed to change appart from some package.json files, with apparently unrelated content. So, I guess in this specific case no further changes needed to be applied?
Note: I have basically 0 experience setting up & running openshift locally, so I might make some fairly basic mistakes, thanks for the patience.
|
/retitle NO-JIRA: Fixed typo: PodDiscruptionBudget -> PodDisruptionBudget |
openshift-ci
bot
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@MartinSalinas98: This pull request explicitly references no jira issue. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/label px-approved |
openshift-ci
bot
added
px-approved
openshift-ci
bot
added
qe-approved
I created a Jira to track this change - Fixed typo: PodDiscruptionBudget -> PodDisruptionBudget. Update the PR title and reassign the ticket accordingly. |
|
/lgtm |
openshift-ci
bot
added
the
approved
|
/approve |
|
/retitle OCPBUGS-53385: Fixed typo: PodDiscruptionBudget -> PodDisruptionBudget |
openshift-ci
bot
changed the title
|
/retitle OCPBUGS-53385: Fixed typo: PodDiscruptionBudget -> PodDisruptionBudget |
openshift-ci
bot
changed the title
openshift-ci-robot
added
the
jira/valid-bug
|
@MartinSalinas98: This pull request references Jira Issue OCPBUGS-53385, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/remove-label px-approved |
openshift-ci
bot
removed
px-approved
|
@MartinSalinas98: This pull request references Jira Issue OCPBUGS-53385, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
2 similar comments
|
/label acknowledge-critical-fixes-only |
openshift-ci
bot
added
the
acknowledge-critical-fixes-only
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cajieh, logonoff, MartinSalinas98 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@MartinSalinas98: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@MartinSalinas98: Jira Issue OCPBUGS-53385: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-53385 has been moved to the MODIFIED state. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Co-authored-by: Martin Salinas <[email protected]>
No description provided.