CONSOLE-4760: update CRD list to use ResourceDataView #15469
Conversation
openshift-ci-robot
added
the
jira/valid-reference
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
@rhamilto: This pull request references CONSOLE-4760 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
component/core
openshift-ci
bot
added
the
kind/cypress
|
@rhamilto: This pull request references CONSOLE-4760 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@rhamilto: This pull request references CONSOLE-4760 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@rhamilto: This pull request references CONSOLE-4760 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest |
1 similar comment
|
/retest |
rhamilto
force-pushed
the
CONSOLE-4760
branch
3 times, most recently
from
0552d27 to
8d4dc19
Compare
|
code approval: |
|
@rhamilto: GitHub didn't allow me to assign the following users: jseseCCS. Note that only openshift members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
rhamilto
force-pushed
the
CONSOLE-4760
branch
2 times, most recently
from
c025b12 to
f116745
Compare
Other than above issues on mobile, the pagination, filtering, ordering works well on different browsers |
Good catch. This is an upstream bug.
Hmm. It appears to be working for me. Can you elaborate on what you're seeing? Screen.Recording.2025-09-10.at.9.32.37.AM.mov |
| return ( | ||
| <div> | ||
| {!_.isEmpty(data) && Filter} | ||
| {!omitFilterToolbar && !_.isEmpty(data) && Filter} |
There was a problem hiding this comment.
Need to be able to omit the legacy <FilterToolbar> on list pages that are updated to use <ResourceDataView> as it includes its own filters.
|
/retest |
rhamilto
force-pushed
the
CONSOLE-4760
branch
from
1b6487f to
1c87ccc
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhamilto, TheRealJon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
aside from the known issues https://github.com/patternfly/react-data-view/issues/506, this looks great!
also: i am seeing a horizontal scrollbar in the empty state, but this only happens on Firefox. weird:
also also: maybe there should be some options to align the content within cells? I understand why we are aligning things to the top-left, but the alignment here looks a little off:
| return ( | ||
| <React.Suspense fallback={<LoadingBox />}> | ||
| <Table | ||
| <ResourceDataView |
There was a problem hiding this comment.
nit: this isn't really needed but I think adding type parameters is the intention when using this component
| <ResourceDataView | |
| <ResourceDataView<CustomResourceDefinitionKind> |
There was a problem hiding this comment.
|
/verified by @yapei |
openshift-ci-robot
added
the
verified
|
@logonoff: This PR has been marked as verified by In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest |
|
/label px-approved |
openshift-ci
bot
added
the
px-approved
|
Jocelyn here from docs. I approve this PR from a style/in-app help perspective. My only feedback is--and I realize this is unrelated to any changes in this PR--the Filter by Name field label is in headline style caps but should be sentence style: Filter by name. Please lmk if there's a more formal way I should give this feedback. Thanks! attn @rhamilto @sferich888 |
@jseseCCS, great catch! If you're ok with it, I can address in a subsequent PR for the epic. |
Fix is in cb293cb#diff-ec7af5e524f203c58f7d45a7ebdb371c229f424ce0a1eccdccb7656bfec78b3c |
|
/label docs-approved |
openshift-ci
bot
added
the
docs-approved
|
@rhamilto: This pull request references CONSOLE-4760 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest |
|
@rhamilto: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Pagination and filtering
Known upstream issue: Pagination controls are not available at smallest viewport sizes
Screen.Recording.2025-09-05.at.2.33.04.PM.mov
Sorting
Screen.Recording.2025-09-05.at.2.33.54.PM.mov
Different viewport sizes
Note the title layout issue is an existing bug.
Screen.Recording.2025-09-05.at.2.36.30.PM.mov