Skip to content

CONSOLE-4720: update Workloads list pages to use ResourceDataView #15492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

CONSOLE-4720: update Workloads list pages to use ResourceDataView #15492

wants to merge 9 commits into from

Conversation

rhamilto
Copy link
Member

@rhamilto rhamilto commented Sep 12, 2025 •
edited
Loading

Duplicates changes also in #15489

This PR updates list views for the following Workloads:

  • public/components/hpa.tsx
  • public/components/job.tsx
  • public/components/pod.jsx
  • public/components/replicaset.jsx
  • public/components/replication-controller.jsx
  • public/components/stateful-set.tsx

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 12, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 12, 2025 •
edited by openshift-ci bot
Loading

@rhamilto: This pull request references CONSOLE-4720 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

Includes changes from #15469, which should merge first.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 12, 2025
@openshift-ci openshift-ci bot added the component/core Related to console core functionality label Sep 12, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 12, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhamilto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added kind/cypress Related to Cypress e2e integration testing approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 12, 2025
@openshift-ci openshift-ci bot added the kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated label Sep 12, 2025
logonoff
logonoff reviewed Sep 13, 2025
View reviewed changes
@rhamilto rhamilto force-pushed the CONSOLE-4720 branch 8 times, most recently from 801b835 to 9e43c49 Compare September 17, 2025 19:55
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 17, 2025
krishagarwal278
krishagarwal278 reviewed Sep 17, 2025
View reviewed changes
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 18, 2025
@rhamilto rhamilto force-pushed the CONSOLE-4720 branch 2 times, most recently from 061cbe5 to 30942f0 Compare September 18, 2025 15:33
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 21, 2025
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 30, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 30, 2025 •
edited by openshift-ci bot
Loading

@rhamilto: This pull request references CONSOLE-4720 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 30, 2025 •
edited by openshift-ci bot
Loading

@rhamilto: This pull request references CONSOLE-4720 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

This PR updates list views for the following Workloads:

  • public/components/hpa.tsx
  • public/components/job.tsx
  • public/components/pod.jsx
  • public/components/replicaset.jsx
  • public/components/replication-controller.jsx
  • public/components/stateful-set.tsx

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rhamilto rhamilto changed the title [WIP] CONSOLE-4720: update Workloads list pages to use ResourceDataView CONSOLE-4720: update Workloads list pages to use ResourceDataView Sep 30, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 30, 2025
@rhamilto
Copy link
Member Author

/test okd-scos-e2e-aws-ovn

@rhamilto
Copy link
Member Author

code approval:
/assign @TheRealJon
qe approval:
/assign @yapei
px approval:
/assign @sferich888
docs approval:
/assign @jseseCCS

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 30, 2025

@rhamilto: GitHub didn't allow me to assign the following users: jseseCCS.

Note that only openshift members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

code approval:
/assign @TheRealJon
qe approval:
/assign @yapei
px approval:
/assign @sferich888
docs approval:
/assign @jseseCCS

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 30, 2025 •
edited by openshift-ci bot
Loading

@rhamilto: This pull request references CONSOLE-4720 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

Duplicates changes also in #15489

This PR updates list views for the following Workloads:

  • public/components/hpa.tsx
  • public/components/job.tsx
  • public/components/pod.jsx
  • public/components/replicaset.jsx
  • public/components/replication-controller.jsx
  • public/components/stateful-set.tsx

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rhamilto
Copy link
Member Author

rhamilto commented Oct 1, 2025

/retest

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 1, 2025

@rhamilto: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

This was referenced Oct 6, 2025
Open
Open
@yapei
Copy link
Contributor

yapei commented Oct 8, 2025

It looks like we are missing number badge besides Pod status, other than this issue others are working fine
Screenshot 2025-10-08 at 11 04 56 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sg00dwin sg00dwin Awaiting requested review from sg00dwin

2 more reviewers

@logonoff logonoff logonoff left review comments

@krishagarwal278 krishagarwal278 krishagarwal278 left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@sferich888 sferich888

@yapei yapei

@TheRealJon TheRealJon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. kind/cypress Related to Cypress e2e integration testing kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@rhamilto @openshift-ci-robot @yapei @logonoff @krishagarwal278 @sferich888 @TheRealJon @openshift-merge-robot