[release-4.19] OCPBUGS-62083: `/auth/error?error=missing_state&error_type=auth` is showing blank page #15523

Leo6Leo · 2025-09-22T19:24:05Z

Description

This is a manual backport for the #15434

…howing empty content (openshift#15434) * fix: add the new auth type under the case that will resolve the issue that the case cannot be found. * fix: retore to the original version * fix: wrap AuthenticationErrorPage with HelmetProvider for proper context * fix: move HelmetProvider to higher up in the tree * refactor: streamline Helmet usage and remove redundant branding details * Update frontend/public/components/app.tsx Co-authored-by: logonoff <[email protected]> * refactor: use the variable name productName --------- Co-authored-by: logonoff <[email protected]>

openshift-ci-robot · 2025-09-22T19:24:11Z

@Leo6Leo: This pull request references Jira Issue OCPBUGS-62083, which is invalid:

release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Description

This is a manual backport for the #15434

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Leo6Leo · 2025-09-22T19:28:21Z

/jira refresh

openshift-ci-robot · 2025-09-22T19:28:29Z

@Leo6Leo: This pull request references Jira Issue OCPBUGS-62083, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.19.z) matches configured target version for branch (4.19.z)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
release note text is set and does not match the template
dependent bug Jira Issue OCPBUGS-60912 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
dependent Jira Issue OCPBUGS-60912 targets the "4.20.0" version, which is one of the valid target versions: 4.20.0
bug has dependents

Requesting review from QA contact:
/cc @yapei

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

vikram-raj · 2025-09-23T05:36:06Z

/retest

logonoff

/lgtm
/label backport-risk-assessed

logonoff · 2025-09-23T14:22:12Z

/retitle [release-4.19] OCPBUGS-62083: /auth/error?error=missing_state&error_type=auth is showing blank page

Leo6Leo · 2025-09-23T14:22:49Z

/hold

#15511 I think I can merge this PR to this backport? @logonoff

logonoff · 2025-09-23T14:23:47Z

#15511 I think I can merge this PR to this backport? @logonoff

Maybe? But I don't want to affect i18n more than needed

Leo6Leo · 2025-09-23T14:25:55Z

#15511 I think I can merge this PR to this backport? @logonoff

Maybe? But I don't want to affect i18n more than needed

Or I can only fix the button link, since it is redirecting to /logout, which doesn't exist. For that link, currently I'm directing it to /, which is the home page of the dashboard, do you think it is reasonable? Or calling logout function would make more sense? @logonoff @TheRealJon

logonoff · 2025-09-23T14:28:28Z

Or I can only fix the button link, since it is redirecting to /logout, which doesn't exist. For that link, currently I'm directing it to /, which is the home page of the dashboard, do you think it is reasonable? Or calling logout function would make more sense? @logonoff @TheRealJon

I think fixing the button link is reasonable here

Leo6Leo · 2025-09-23T19:03:26Z

Can I re-get the tags plz? @logonoff @krishagarwal278

logonoff · 2025-09-23T19:05:46Z

/lgtm

yapei · 2025-09-24T05:19:14Z

frontend/public/components/error.tsx

+      // When the error type is set as auth
+      switch (error) {
+        case 'missing_state':
+          return t('public~There was an error parsing your state cookie');


period is missing here

yapei · 2025-09-24T05:20:09Z

frontend/public/components/error.tsx

    case 'login_state_error':
      return t('public~There was an error generating login state.');
    case 'cookie_error':
      return t('public~There was an error setting login state cookie');


Shall we update message to include period?

it looks like this one also needs to be updated

Opps I missed it, thanks for catching that @yapei , updated.

yapei · 2025-09-24T05:24:08Z

@Leo6Leo It looks like we already have partial change(Try again button redirect link changes) of https://github.com/openshift/console/pull/15511/files here, how about bringing all changes together?
That means we manually backport both #15434 and #15511 changes in this PR, HDYT?

Leo6Leo · 2025-09-25T00:17:31Z

I have manually merged the backport for both #15434 and #15511 as @yapei suggested. I will do the same for release 4.18, 4.17, 4.16, as the backport process has finished for 4.20. I will update the corresponding Jira issues to keep track the process clearly.

Leo6Leo · 2025-09-25T00:17:48Z

For getting lgtm tags:
/cc @logonoff

logonoff

/lgtm

openshift-ci · 2025-09-25T12:43:13Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Leo6Leo, logonoff

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~frontend/OWNERS~~ [logonoff]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Leo6Leo · 2025-09-25T18:22:01Z

For verification:
@yapei

yapei · 2025-09-29T02:31:56Z

visit /auth/error?error_type=cookie_error

visit /auth/error?error=missing_state&error_type=auth

yapei · 2025-09-29T02:32:14Z

/verified by @yapei

openshift-ci-robot · 2025-09-29T02:32:25Z

@yapei: This PR has been marked as verified by @yapei.

In response to this:

/verified by @yapei

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2025-09-29T03:12:16Z

/retest-required

Remaining retests: 0 against base HEAD 34a9f3b and 2 for PR HEAD b5c402e in total

openshift-ci · 2025-09-29T08:34:43Z

@Leo6Leo: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci-robot · 2025-09-29T08:37:47Z

@Leo6Leo: Jira Issue Verification Checks: Jira Issue OCPBUGS-62083
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-62083 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

In response to this:

Description

This is a manual backport for the #15434

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Leo6Leo · 2025-09-29T13:16:21Z

/cherry-pick release-4.18

openshift-cherrypick-robot · 2025-09-29T13:17:31Z

@Leo6Leo: #15523 failed to apply on top of branch "release-4.18":

Applying: OCPBUGS-60912: `/auth/error?error=missing_state&error_type=auth` is showing empty content (#15434)
Using index info to reconstruct a base tree...
M	frontend/public/components/app.jsx
M	frontend/public/components/error.tsx
M	frontend/public/locales/en/public.json
Falling back to patching base and 3-way merge...
Auto-merging frontend/public/locales/en/public.json
Auto-merging frontend/public/components/error.tsx
CONFLICT (content): Merge conflict in frontend/public/components/error.tsx
Auto-merging frontend/public/components/app.jsx
CONFLICT (content): Merge conflict in frontend/public/components/app.jsx
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 OCPBUGS-60912: `/auth/error?error=missing_state&error_type=auth` is showing empty content (#15434)

In response to this:

/cherry-pick release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

…9/auth-error-page [release-4.19] OCPBUGS-62083: `/auth/error?error=missing_state&error_type=auth` is showing blank page

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 22, 2025

openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Sep 22, 2025

openshift-ci bot requested review from jhadvig and kyoto September 22, 2025 19:24

openshift-ci bot added component/core Related to console core functionality kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated labels Sep 22, 2025

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 22, 2025

openshift-ci bot requested a review from yapei September 22, 2025 19:28

logonoff reviewed Sep 23, 2025

View reviewed changes

openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Sep 23, 2025

openshift-ci bot assigned sanketpathak, XiyunZhao, yanpzhan and yapei Sep 23, 2025

openshift-ci bot changed the title ~~[Release-4.19] OCPBUGS-62083: /auth/error?error=missing_state&error_type=auth is showing blank page~~ [release-4.19] OCPBUGS-62083: /auth/error?error=missing_state&error_type=auth is showing blank page Sep 23, 2025

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 23, 2025

openshift-ci bot assigned logonoff Sep 23, 2025

openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 23, 2025

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 23, 2025

yapei reviewed Sep 24, 2025

View reviewed changes

Leo6Leo added 2 commits September 24, 2025 20:00

fix: add missing period to error message for improved clarity

15fc213

fix: correct punctuation in error message for consistency

778dac1

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 25, 2025

openshift-ci bot requested a review from logonoff September 25, 2025 00:17

fix: add missing period to error message for consistency in localization

b5c402e

Leo6Leo requested a review from yapei September 25, 2025 02:15

logonoff approved these changes Sep 25, 2025

View reviewed changes

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 25, 2025

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Sep 29, 2025

openshift-merge-bot bot merged commit c200672 into openshift:release-4.19 Sep 29, 2025
8 checks passed

Leo6Leo added a commit to Leo6Leo/console that referenced this pull request Sep 29, 2025

Merge pull request openshift#15523 from Leo6Leo/leo/ocpbugs/62083/4-1…

21fc676

…9/auth-error-page [release-4.19] OCPBUGS-62083: `/auth/error?error=missing_state&error_type=auth` is showing blank page

[release-4.19] OCPBUGS-62083: /auth/error?error=missing_state&error_type=auth is showing blank page #15523

[release-4.19] OCPBUGS-62083: /auth/error?error=missing_state&error_type=auth is showing blank page #15523

Uh oh!

Conversation

Leo6Leo commented Sep 22, 2025

Description

Uh oh!

openshift-ci-robot commented Sep 22, 2025

Description

Uh oh!

Leo6Leo commented Sep 22, 2025

Uh oh!

openshift-ci-robot commented Sep 22, 2025

Uh oh!

vikram-raj commented Sep 23, 2025

Uh oh!

logonoff left a comment

Choose a reason for hiding this comment

Uh oh!

logonoff commented Sep 23, 2025

Uh oh!

Leo6Leo commented Sep 23, 2025

Uh oh!

logonoff commented Sep 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Leo6Leo commented Sep 23, 2025

Uh oh!

logonoff commented Sep 23, 2025

Uh oh!

Leo6Leo commented Sep 23, 2025

Uh oh!

logonoff commented Sep 23, 2025

Uh oh!

yapei Sep 24, 2025

Choose a reason for hiding this comment

Uh oh!

yapei Sep 24, 2025

Choose a reason for hiding this comment

Uh oh!

yapei Sep 25, 2025

Choose a reason for hiding this comment

Uh oh!

Leo6Leo Sep 25, 2025

Choose a reason for hiding this comment

Uh oh!

yapei commented Sep 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Leo6Leo commented Sep 25, 2025

Uh oh!

Leo6Leo commented Sep 25, 2025

Uh oh!

logonoff left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci bot commented Sep 25, 2025

Uh oh!

Leo6Leo commented Sep 25, 2025

Uh oh!

yapei commented Sep 29, 2025

Uh oh!

yapei commented Sep 29, 2025

Uh oh!

openshift-ci-robot commented Sep 29, 2025

Uh oh!

openshift-ci-robot commented Sep 29, 2025

Uh oh!

openshift-ci bot commented Sep 29, 2025

Uh oh!

Uh oh!

openshift-ci-robot commented Sep 29, 2025

Description

Uh oh!

Leo6Leo commented Sep 29, 2025

Uh oh!

openshift-cherrypick-robot commented Sep 29, 2025

Uh oh!

Uh oh!

[release-4.19] OCPBUGS-62083: `/auth/error?error=missing_state&error_type=auth` is showing blank page #15523

[release-4.19] OCPBUGS-62083: `/auth/error?error=missing_state&error_type=auth` is showing blank page #15523

logonoff commented Sep 23, 2025 •

edited

Loading

yapei commented Sep 24, 2025 •

edited

Loading