Bug 2001413: add/delete nic and disk to template #9996

gouyang · 2021-09-06T03:38:55Z

note for review:

rename tests/disks to tests/disk, tests/vm-templates to tests/template

openshift-ci · 2021-09-06T03:39:02Z

@gouyang: This pull request references Bugzilla bug 2001413, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.9.0) matches configured target release for branch (4.9.0)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @gouyang

In response to this:

Bug 2001413: add/delete nic and disk to template

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2021-09-06T03:39:04Z

@openshift-ci[bot]: GitHub didn't allow me to request PR reviews from the following users: gouyang.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@gouyang: This pull request references Bugzilla bug 2001413, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)

bug target release (4.9.0) matches configured target release for branch (4.9.0)

bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @gouyang

In response to this:

Bug 2001413: add/delete nic and disk to template

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

gouyang · 2021-09-06T07:14:16Z

/retest

openshift-merge-robot · 2021-09-06T07:20:37Z

/bugzilla refresh

The requirements for Bugzilla bugs have changed, recalculating validity.

openshift-ci · 2021-09-06T07:23:43Z

@openshift-merge-robot: This pull request references Bugzilla bug 2001413, which is invalid:

expected the bug to target the "4.10.0" release, but it targets "4.9.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

The requirements for Bugzilla bugs have changed, recalculating validity.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

gouyang · 2021-09-06T09:16:57Z

/bugzilla refresh

openshift-ci · 2021-09-06T09:17:02Z

@gouyang: This pull request references Bugzilla bug 2001413, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.10.0) matches configured target release for branch (4.10.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @gouyang

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2021-09-06T09:17:03Z

@openshift-ci[bot]: GitHub didn't allow me to request PR reviews from the following users: gouyang.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@gouyang: This pull request references Bugzilla bug 2001413, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)

bug target release (4.10.0) matches configured target release for branch (4.10.0)

bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @gouyang

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

gouyang · 2021-09-06T13:50:42Z

/retest

gouyang · 2021-09-07T03:37:36Z

/retest

gouyang · 2021-09-07T08:31:44Z

/retest

gouyang · 2021-09-08T08:06:31Z

/retest

openshift-ci · 2021-09-08T11:52:57Z

@gouyang: This pull request references Bugzilla bug 2001413, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.10.0) matches configured target release for branch (4.10.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @gouyang

In response to this:

Bug 2001413: add/delete nic and disk to template

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2021-09-08T11:52:58Z

@openshift-ci[bot]: GitHub didn't allow me to request PR reviews from the following users: gouyang.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@gouyang: This pull request references Bugzilla bug 2001413, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)

bug target release (4.10.0) matches configured target release for branch (4.10.0)

bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @gouyang

In response to this:

Bug 2001413: add/delete nic and disk to template

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pcbailey

Just a few nitpicks. I would have went ahead and approved it and say we could fix them in a followup, but it needs a rebase to fix the errorOccurred change from #10017 as well.

pcbailey · 2021-09-08T18:44:55Z

...kubevirt-plugin/integration-tests-cypress/tests/template/create-template-from-wizard.spec.ts

nitpick: Template shouldn't be capitalized here.

pcbailey · 2021-09-08T18:45:06Z

.../packages/kubevirt-plugin/integration-tests-cypress/tests/template/template-resource.spec.ts

nitpick: Template shouldn't be capitalized here.

pcbailey · 2021-09-08T18:45:59Z

.../packages/kubevirt-plugin/integration-tests-cypress/tests/template/template-resource.spec.ts

nitpick: 'user created' => 'user-created'

pcbailey · 2021-09-08T18:46:22Z

.../packages/kubevirt-plugin/integration-tests-cypress/tests/template/template-resource.spec.ts

nitpick: 'to' => 'to/from'

pcbailey · 2021-09-08T18:46:27Z

.../packages/kubevirt-plugin/integration-tests-cypress/tests/template/template-resource.spec.ts

nitpick: 'to' => 'to/from'

gouyang · 2021-09-09T06:51:45Z

/retest

gouyang · 2021-09-09T09:28:47Z

@yaacov @pcbailey PTAL, thanks!
Note: I reverted the fix for flaky in tests/smoke/actions, added a clear wait cy.wait(5000) to vm.start() and vm.restart().

pcbailey · 2021-09-09T10:59:49Z

/lgtm

gouyang · 2021-09-09T12:55:16Z

/retest

openshift-bot · 2021-09-09T16:26:55Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-09-09T17:31:54Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

gouyang · 2021-09-10T04:32:58Z

/retest

pcbailey · 2021-09-10T11:32:15Z

/lgtm

pcbailey · 2021-09-10T12:02:06Z

/lgtm

openshift-ci · 2021-09-10T12:03:31Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gouyang, pcbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~frontend/packages/kubevirt-plugin/OWNERS~~ [pcbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2021-09-10T14:02:21Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-09-10T15:51:21Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-09-10T16:27:21Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-09-10T17:16:04Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-ci · 2021-09-10T21:03:52Z

@gouyang: All pull requests linked via external trackers have merged:

openshift/console#9996

Bugzilla bug 2001413 has been moved to the MODIFIED state.

In response to this:

Bug 2001413: add/delete nic and disk to template

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci bot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Sep 6, 2021

openshift-ci bot requested review from pcbailey and rhrazdil September 6, 2021 03:39

openshift-ci bot added the component/kubevirt Related to kubevirt-plugin label Sep 6, 2021

gouyang force-pushed the template_resource branch from 738a3c8 to b7f7d3a Compare September 6, 2021 03:41

openshift-ci bot removed the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Sep 6, 2021

openshift-ci bot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Sep 6, 2021

openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Sep 6, 2021

gouyang force-pushed the template_resource branch 3 times, most recently from f97906d to 54e72f0 Compare September 8, 2021 04:29

pcbailey suggested changes Sep 8, 2021

View reviewed changes

gouyang force-pushed the template_resource branch 2 times, most recently from 78e26ff to ea064de Compare September 9, 2021 03:41

openshift-ci bot assigned pcbailey Sep 9, 2021

openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 9, 2021

openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 9, 2021

gouyang force-pushed the template_resource branch from ea064de to b9afdbc Compare September 9, 2021 23:48

openshift-ci bot removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Sep 9, 2021

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 10, 2021

Bug 2001413: add/delete nic and disk to/from template

e3febd8

gouyang force-pushed the template_resource branch from b9afdbc to e3febd8 Compare September 10, 2021 11:58

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 10, 2021

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 10, 2021

openshift-merge-robot merged commit 5f68ac2 into openshift:master Sep 10, 2021

spadgett added this to the v4.10 milestone Sep 23, 2021

Bug 2001413: add/delete nic and disk to template #9996

Bug 2001413: add/delete nic and disk to template #9996

Uh oh!

Conversation

gouyang commented Sep 6, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci bot commented Sep 6, 2021

Uh oh!

openshift-ci bot commented Sep 6, 2021

Uh oh!

gouyang commented Sep 6, 2021

Uh oh!

openshift-merge-robot commented Sep 6, 2021

Uh oh!

openshift-ci bot commented Sep 6, 2021

Uh oh!

gouyang commented Sep 6, 2021

Uh oh!

openshift-ci bot commented Sep 6, 2021

Uh oh!

openshift-ci bot commented Sep 6, 2021

Uh oh!

gouyang commented Sep 6, 2021

Uh oh!

gouyang commented Sep 7, 2021

Uh oh!

gouyang commented Sep 7, 2021

Uh oh!

gouyang commented Sep 8, 2021

Uh oh!

openshift-ci bot commented Sep 8, 2021

Uh oh!

openshift-ci bot commented Sep 8, 2021

Uh oh!

pcbailey left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gouyang commented Sep 9, 2021

Uh oh!

gouyang commented Sep 9, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pcbailey commented Sep 9, 2021

Uh oh!

gouyang commented Sep 9, 2021

Uh oh!

openshift-bot commented Sep 9, 2021

Uh oh!

openshift-bot commented Sep 9, 2021

Uh oh!

gouyang commented Sep 10, 2021

Uh oh!

pcbailey commented Sep 10, 2021

Uh oh!

pcbailey commented Sep 10, 2021

Uh oh!

openshift-ci bot commented Sep 10, 2021

Uh oh!

openshift-bot commented Sep 10, 2021

gouyang commented Sep 6, 2021 •

edited

Loading

gouyang commented Sep 9, 2021 •

edited

Loading