CORENET-6373: ovn-k, virt, preconfigured udn addresses: Test MAC conflict detection #30314
Conversation
Validates that KubeVirt VMs with preconfigured MAC and IP addresses maintain those addresses correctly before and after a vmi with duplicate IP/MAC request is made, and that the vmi with the duplicate address get the appropriate address conflict error event. Co-authored-by: Miguel Duarte Barroso <[email protected]> Signed-off-by: Ram Lavi <[email protected]>
The requested IPs for the primary UDN attachment are not in the VMI spec, but in an annotation in the VMI. Hence, we need to fetch that particular annotation, and set it in the duplicate VMI. This was implemented using the builder pattern, since I suspect in the future we will need to further customize the VMI spec / metadata; this will make it simpler to extend the framework in the future. Signed-off-by: Miguel Duarte Barroso <[email protected]>
This way we can ensure appropriate cases are caught in a generic way. With it, we can safely expect to find IP conflicts when there are duplicate IPs in the network. In future commits, we will be able to catch MAC conflicts when there are duplicate MACs in the network Co-authored-by: Ram Lavi <[email protected]> Signed-off-by: Miguel Duarte Barroso <[email protected]>
openshift-merge-robot
added
the
needs-rebase
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
ormergi
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@ormergi: This pull request references CORENET-6373 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.21." or "openshift-4.21.", but it targets "openshift-4.20" instead. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/tide refresh |
ormergi
force-pushed
the
preconfigured-udn-addresses-e2e-mac-conflict-detection
branch
from
d1b63ed to
77b39ed
Compare
|
/test e2e-metal-ipi-ovn-bgp-virt-dualstack-techpreview |
|
/testwith openshift/origin/main/e2e-metal-ipi-ovn-bgp-virt-dualstack-techpreview openshift/ovn-kubernetes#2769 |
ormergi
force-pushed
the
preconfigured-udn-addresses-e2e-mac-conflict-detection
branch
from
77b39ed to
7076438
Compare
openshift-merge-robot
removed
the
needs-rebase
|
/testwith openshift/origin/main/e2e-metal-ipi-ovn-bgp-virt-dualstack-techpreview openshift/ovn-kubernetes#2769 |
|
Previous job fail to start |
|
/testwith openshift/origin/main/e2e-metal-ipi-ovn-bgp-virt-dualstack-techpreview openshift/ovn-kubernetes#2769 |
ormergi
force-pushed
the
preconfigured-udn-addresses-e2e-mac-conflict-detection
branch
from
7076438 to
94383a7
Compare
openshift-merge-robot
added
the
needs-rebase
Verify KubeVirt VMs with preconfigured MAC address retain a requested MAC address before and after another VM is created requesting the same MAC address. And verify the other VM requesting the same MAC address get the appropriate address conflict error event. Signed-off-by: Or Mergi <[email protected]>
ormergi
force-pushed
the
preconfigured-udn-addresses-e2e-mac-conflict-detection
branch
from
94383a7 to
c7dbb14
Compare
openshift-merge-robot
removed
the
needs-rebase
|
/testwith openshift/origin/main/e2e-metal-ipi-ovn-bgp-virt-dualstack-techpreview openshift/ovn-kubernetes#2769 |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ormergi The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
@ormergi: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/cc @maiqueb |
Rebased on #30197 (first 3 commits)
This PR is a followup PR to #30010 #30197, adding tests to check MAC conflict detection:
create VM with Preconfigured MAC, assert MAC conflict are detected