Skip to content

Consider moving DefaultConfigurationService and AnnotationControllerConfiguration into core module #1012

Closed
@metacosm

Description

@metacosm
Collaborator

The initial thinking was that there were not needed in the core but not having them is actually causing more problems than having them there.

Activity

self-assigned this
on Mar 9, 2022
metacosm

metacosm commented on Mar 9, 2022

@metacosm
CollaboratorAuthor

Actually was a little too optimistic about it. I had forgotten about the fact that AnnotationControllerConfiguration requires an annotation processor to run to work properly, which shouldn't be brought into the core module, so this wouldn't be as straightforward as initially thought. We would need a "pure" runtime annotation processing version of AnnotationControllerConfiguration but then the question becomes how to share the behavior between the modules.

added a commit that references this issue on Mar 9, 2022
1bf513b
added 2 commits that reference this issue on Mar 10, 2022
ad3b508
808228f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

    Participants

    @jmrodri@metacosm

    Issue actions

      Consider moving `DefaultConfigurationService` and `AnnotationControllerConfiguration` into core module · Issue #1012 · operator-framework/java-operator-sdk