Skip to content

feat: add non-apt-tied behavior annotation and configuration to core #1013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 10, 2022
Merged

feat: add non-apt-tied behavior annotation and configuration to core #1013

merged 2 commits into from
Mar 10, 2022

Conversation

metacosm
Copy link
Collaborator

@metacosm metacosm commented Mar 9, 2022

Fixes #1012

@metacosm metacosm self-assigned this Mar 9, 2022
@metacosm metacosm requested a review from csviri March 9, 2022 19:47
@metacosm metacosm mentioned this pull request Mar 9, 2022
Merged
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 54 Code Smells

36.5% 36.5% Coverage
0.0% 0.0% Duplication

@metacosm metacosm linked an issue Mar 9, 2022 that may be closed by this pull request
Consider moving DefaultConfigurationService and AnnotationControllerConfiguration into core module #1012
Closed
@csviri
Copy link
Collaborator

csviri commented Mar 10, 2022

LGTM,

(maybe one thing to consider to name differently the two AnnotationControllerConfiguration classes.)

@metacosm
Copy link
Collaborator Author

metacosm commented Mar 10, 2022 •
edited
Loading

(maybe one thing to consider to name differently the two AnnotationControllerConfiguration classes.)

They're in different packages and modules and we do something similar already with ControllerConfiguration but yes, maybe we should rename the new one. Any idea?

I was also thinking that maybe we should also rename BaseConfigurationService. What do you think?

@metacosm
Copy link
Collaborator Author

Will do these changes in a follow-up PR if needed.

@metacosm metacosm merged commit 808228f into next Mar 10, 2022
@metacosm metacosm deleted the fix-1012 branch March 10, 2022 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csviri csviri csviri approved these changes

Assignees

@metacosm metacosm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider moving DefaultConfigurationService and AnnotationControllerConfiguration into core module
2 participants
@metacosm @csviri