Skip to content

Add isomorphism(::Type{PermGroup}, ::WeylGroup) for some cases#4264

Merged
lgoettgens merged 7 commits intooscar-system:masterfrom
lgoettgens:adv+lg/weyl-perm
Nov 1, 2024
Merged

Add isomorphism(::Type{PermGroup}, ::WeylGroup) for some cases#4264
lgoettgens merged 7 commits intooscar-system:masterfrom
lgoettgens:adv+lg/weyl-perm

Conversation

@lgoettgens
Copy link
Copy Markdown
Member

This PR contains the changes from #4260 in experimental/LieAlgebras, makes them a bit more consistent with the surrounding code, and adds tests.

@lgoettgens lgoettgens added topic: lie theory experimental Only changes experimental parts of the code labels Oct 31, 2024
@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 1, 2024

Codecov Report

Attention: Patch coverage is 89.28571% with 3 lines in your changes missing coverage. Please review.

Project coverage is 84.60%. Comparing base (852b6d1) to head (2286d23).
Report is 295 commits behind head on master.

Files with missing lines Patch % Lines
experimental/LieAlgebras/src/WeylGroup.jl 89.28% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4264      +/-   ##
==========================================
- Coverage   84.60%   84.60%   -0.01%     
==========================================
  Files         640      640              
  Lines       85128    85145      +17     
==========================================
+ Hits        72021    72034      +13     
- Misses      13107    13111       +4     
Files with missing lines Coverage Δ
experimental/LieAlgebras/src/LieAlgebras.jl 100.00% <ø> (ø)
experimental/LieAlgebras/test/WeylGroup-test.jl 97.77% <ø> (ø)
experimental/LieAlgebras/src/WeylGroup.jl 92.03% <89.28%> (-0.25%) ⬇️

... and 3 files with indirect coverage changes

@lgoettgens lgoettgens enabled auto-merge (squash) November 1, 2024 11:24
@lgoettgens lgoettgens disabled auto-merge November 1, 2024 11:24
@lgoettgens lgoettgens enabled auto-merge (squash) November 1, 2024 11:35
@lgoettgens lgoettgens merged commit 24a31de into oscar-system:master Nov 1, 2024
@lgoettgens lgoettgens deleted the adv+lg/weyl-perm branch November 25, 2024 15:05
@fingolfin fingolfin added the release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes label Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

experimental Only changes experimental parts of the code release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes topic: lie theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants