Skip to content

Add isomorphism(PermGroup, ::WeylGroup) for missing irreducible types#4478

Merged
fingolfin merged 13 commits intooscar-system:masterfrom
TWiedemann:tw/weylgroup_as_permgroup
Jan 20, 2025
Merged

Add isomorphism(PermGroup, ::WeylGroup) for missing irreducible types#4478
fingolfin merged 13 commits intooscar-system:masterfrom
TWiedemann:tw/weylgroup_as_permgroup

Conversation

@TWiedemann
Copy link
Copy Markdown
Contributor

Adds support for all missing irreducible types (B, C, D, E, F, G) in isomorphism(PermGroup, ::WeylGroup) and also for non-canonical orderings. Reducible types are still missing.

@lgoettgens I don't know whether this should be merged already, but I think the code is mature enough for someone else to have a look.

@TWiedemann
Copy link
Copy Markdown
Contributor Author

This is a continuation of #4264, I guess.

@lgoettgens lgoettgens added topic: lie theory experimental Only changes experimental parts of the code labels Jan 17, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.40%. Comparing base (91f076a) to head (c5def11).
Report is 71 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4478      +/-   ##
==========================================
+ Coverage   84.36%   84.40%   +0.03%     
==========================================
  Files         663      672       +9     
  Lines       87805    88708     +903     
==========================================
+ Hits        74077    74873     +796     
- Misses      13728    13835     +107     
Files with missing lines Coverage Δ
experimental/LieAlgebras/src/WeylGroup.jl 94.73% <100.00%> (+5.60%) ⬆️
experimental/LieAlgebras/test/WeylGroup-test.jl 100.00% <ø> (ø)

... and 76 files with indirect coverage changes

Copy link
Copy Markdown
Member

@lgoettgens lgoettgens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I have a few comments, mostly documentation-related. Once they are resolved, I would be happy to merge this PR. If you prefer to wait until reducible types are working, this would be fine for me as well.

Comment thread experimental/LieAlgebras/src/WeylGroup.jl Outdated
Comment thread experimental/LieAlgebras/src/WeylGroup.jl Outdated
Comment thread experimental/LieAlgebras/src/WeylGroup.jl Outdated
Comment thread experimental/LieAlgebras/src/WeylGroup.jl
Comment thread experimental/LieAlgebras/src/WeylGroup.jl Outdated
TWiedemann and others added 6 commits January 17, 2025 13:40
Co-authored-by: Lars Göttgens <lars.goettgens@gmail.com>
Co-authored-by: Lars Göttgens <lars.goettgens@gmail.com>
Co-authored-by: Lars Göttgens <lars.goettgens@gmail.com>
Co-authored-by: Lars Göttgens <lars.goettgens@gmail.com>
@TWiedemann
Copy link
Copy Markdown
Contributor Author

Thanks for your comments! I resolved everything. I plan to look into the reducible types soonish, but I see no harm in merging already.

Copy link
Copy Markdown
Member

@lgoettgens lgoettgens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the adaptions! Could you please have a look into the two failing CI jobs? Both should have some instructions in the failure log. Once that's done, this is good to go from my POV.

Comment thread docs/oscar_references.bib Outdated
Comment thread docs/oscar_references.bib Outdated
TWiedemann and others added 2 commits January 17, 2025 16:49
Co-authored-by: Lars Göttgens <lars.goettgens@gmail.com>
Co-authored-by: Lars Göttgens <lars.goettgens@gmail.com>
@TWiedemann
Copy link
Copy Markdown
Contributor Author

Thanks for the adaptions! Could you please have a look into the two failing CI jobs? Both should have some instructions in the failure log. Once that's done, this is good to go from my POV.

Sure, will do that next week.

@TWiedemann
Copy link
Copy Markdown
Contributor Author

TWiedemann commented Jan 20, 2025

I applied JuliaFormatter and bibtool and fixed the bib entry (changed "article" to "Article"). Now it's all fine (except for the nightly test).

end
else
error("Not implemented (yet)")
Sym = symmetric_group(n + 1)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as a general rule of thumb, use lowercase first letters for variables, and reserver Upper case for types. Main except for me is for single letter variables; but even there I'd recommend sym or S here.

But this is not a blocker for this PR, just a general remark for future reference :-)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I will keep that in mind :)

end

iso = function (w::WeylGroupElem)
reduce(*, (gen(G, Int(i)) for i in word(w)); init=one(G))
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest that we instead install a variant of this line as a method for map_word on WeylGroupElem, and then call map_word here.

Of course this can wait for a future PR!

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. This would, in particular, remove the potential error source of not converting "i in word(w)" from UInt to Int.

@fingolfin fingolfin merged commit 1e2a345 into oscar-system:master Jan 20, 2025
@aaruni96 aaruni96 added the release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes label Jan 30, 2025
@fingolfin fingolfin changed the title isomorphism(PermGroup, ::WeylGroup) for missing irreducible types Add isomorphism(PermGroup, ::WeylGroup) for missing irreducible types Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

experimental Only changes experimental parts of the code release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes topic: lie theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants