Fix characteristic method for localized rings#4346
Merged
lgoettgens merged 1 commit intooscar-system:masterfrom Nov 25, 2024
Merged
Fix characteristic method for localized rings#4346lgoettgens merged 1 commit intooscar-system:masterfrom
characteristic method for localized rings#4346lgoettgens merged 1 commit intooscar-system:masterfrom
Conversation
lgoettgens
changed the title
characteristic method for of localized rings.
HechtiDerLachs
changed the title
characteristic method for of localized rings.characteristic method for localized rings.
Collaborator
|
Thanks. The problems with polynomial rings over zero rings are being addressed elsewhere. |
thofma
approved these changes
Nov 25, 2024
Collaborator
Author
|
Alright. I hope the tests pass. I do not oversee at the moment to which extent we have been using the |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4346 +/- ##
==========================================
- Coverage 84.52% 84.52% -0.01%
==========================================
Files 645 645
Lines 85706 85710 +4
==========================================
+ Hits 72440 72443 +3
- Misses 13266 13267 +1
|
Merged
benlorenz
pushed a commit
that referenced
this pull request
Dec 12, 2024
(cherry picked from commit f849adc)
benlorenz
added a commit
that referenced
this pull request
Dec 13, 2024
Backports for release 1.2.2: fix galois_group problem. #4396 Fix zero-dimensional cone in cones in PolyhedralGeometry #4336 Fix up generic characteristic method for localized rings. #4346 test/PolyhedralGeometry: remove some prefer blocks #4351 Add comment about bibtool version, minor fix in testsuite #4356 Add hash method for RayVector #4354 Fix indent in AlgebraicCycles.md #4368 Fix toric typo #4367
fingolfin
changed the title
characteristic method for localized rings.characteristic method for localized rings
fingolfin
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to address #4324.
@thofma : The second issue pointed out by you in #4324 is not yet resolved with this. Does the ball lay in my yard with that one, too? Or is it an issue of polynomial rings?