Add comment about bibtool version, minor fix in testsuite#4356
Merged
HereAround merged 2 commits intomasterfrom Nov 27, 2024
Merged
Add comment about bibtool version, minor fix in testsuite#4356HereAround merged 2 commits intomasterfrom
HereAround merged 2 commits intomasterfrom
Conversation
fingolfin
approved these changes
Nov 27, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4356 +/- ##
=======================================
Coverage 84.32% 84.32%
=======================================
Files 649 649
Lines 86430 86430
=======================================
Hits 72882 72882
Misses 13548 13548 |
HereAround
approved these changes
Nov 27, 2024
Member
HereAround
left a comment
HereAround
left a comment
There was a problem hiding this comment.
Looks good! Thank you for working on this @lkastner !
Merged
benlorenz
pushed a commit
that referenced
this pull request
Dec 12, 2024
(cherry picked from commit 9348958)
benlorenz
added a commit
that referenced
this pull request
Dec 13, 2024
Backports for release 1.2.2: fix galois_group problem. #4396 Fix zero-dimensional cone in cones in PolyhedralGeometry #4336 Fix up generic characteristic method for localized rings. #4346 test/PolyhedralGeometry: remove some prefer blocks #4351 Add comment about bibtool version, minor fix in testsuite #4356 Add hash method for RayVector #4354 Fix indent in AlgebraicCycles.md #4368 Fix toric typo #4367
lgoettgens
added
the
release notes: not needed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running with different bibtool version may produce wrong results.
Fix remnants of #4348, ie fix #4355
cc @HereAround