Backfill 1.2.2 to changelog#4472
Conversation
fingolfin
left a comment
There was a problem hiding this comment.
Thank you, I think this is a good idea in principle.
But I would suggest to link to the PRs that implemented a fix. That way one can easily find out more information about a given fix.
Co-authored-by: Max Horn <max@quendi.de>
|
BTW, not a complaint, but, why isn't this in PR #4448? Don't they basically do the same thing, i.e. add CHANGELOG.md, just with different content? |
|
|
||
| ### Fixed | ||
|
|
||
| - Fixed a problem with `galois_group` [PR #4396](https://github.com/oscar-system/Oscar.jl/pull/4396) |
There was a problem hiding this comment.
That's better. I've now adjusted #4396 to use this as title, and added the "use title" label.
We also should add labels reflecting the categories we use. While I am still not convinced that "Added" / "Changed" / etc. are what we want (after all the description usually makes that clear already: "Fixed a problem with ..."), I am OK with trying that out for now, we can then iterate.
But that would suggestion suitable labels. E.g. category: change, category: fix, category: addition (or any different prefix, like kind: or type:. Or no prefix, whatever. As long as there is a way to find out which labels are relevant. Having a common prefix simply makes that easier)
|
Closed in favor of #4448 |
This depends on #4448 , just a first draft of what a backfilled changelog for v1.2.2 could look like.
This skips the following compared to the autogenerated changelog in the release page :