Internal and documentation improvements#4486
Merged
HereAround merged 3 commits intooscar-system:masterfrom Jan 19, 2025
Merged
Conversation
8aaf273 to
a918ca2
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4486 +/- ##
=======================================
Coverage 84.39% 84.39%
=======================================
Files 672 672
Lines 88690 88697 +7
=======================================
+ Hits 74846 74855 +9
+ Misses 13844 13842 -2
|
…dom_flux_instance
emikelsons
approved these changes
Jan 19, 2025
Collaborator
emikelsons
left a comment
There was a problem hiding this comment.
Looks good and the tests pass
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_strict_transform(no longer needed thx to Improve performance of strict transform under toric blowups #4484).torsion_sectionsand add its documentation.I did not (yet) check in detail if all our docstrings are also quote in the docs folder/explained there. Note that those docstring that do not appear in the docs folder do not appear on the website. Maybe @emikelsons could verify if more is missing?
Modulo this (minor) caveat, the above should be ready for review.