FTheory: More documentation and related improvements#5071
FTheory: More documentation and related improvements#5071HereAround merged 30 commits intomasterfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5071 +/- ##
==========================================
- Coverage 84.90% 84.89% -0.01%
==========================================
Files 706 706
Lines 95421 95482 +61
==========================================
+ Hits 81017 81064 +47
- Misses 14404 14418 +14
🚀 New features to boost your workflow:
|
0dd09ed to
bba0115
Compare
ee85584 to
2e59fe4
Compare
…returning the argument
4535b77 to
3ab40f4
Compare
3ab40f4 to
dcecfaa
Compare
c0240e7 to
a333f24
Compare
a333f24 to
7823dcb
Compare
7bd48a5 to
e882bc9
Compare
e882bc9 to
76aa493
Compare
|
|
||
| Resolve an F-theory model by blowing up a locus in the ambient space. | ||
|
|
||
| # Examples |
There was a problem hiding this comment.
Why are we removing # Examples, isn't the use of this subtitle above code samples common practice throughout the Oscar docs?
There was a problem hiding this comment.
At least we (=FTheoryTools) were not consistent with this. To me it seemed that most of the FTheoryTools doc strings did not have the #Example and so I removed it.
(I also like simplicity. To me it seems clear that what follows below the description is an example. So why state the obvious? But this is definitely not too important and maybe even incorrect - perceptions can be different.)
I am happy to add this back if you feel this is preferred, but then adding it to all doc strings.
There was a problem hiding this comment.
I don't really have a strong opinion either way and was just pointing out what I had noticed, but maybe it's best then to leave these changes.
There was a problem hiding this comment.
According to our style guide (https://docs.oscar-system.org/dev/DeveloperDocumentation/documentation/#Docstrings-of-exported-functions), the # Examples should be there
emikelsons
left a comment
There was a problem hiding this comment.
Looks good and the tests seem to pass!
Release notes:
HypersurfaceModelconstructors.set_weierstrass_model(h::HypersurfaceModel).set_global_tate_model(h::HypersurfaceModel).sample_toric_variety().weierstrass_model(w::WeierstrassModel).What is in this PR:
hypersurface_equationfor Weierstrass and global Tate models.set_weierstrass_modelandset_global_tate_modelfor hypersurface models.sample_toric_variety.Preview of the overhauled documentation should become available at https://docs.oscar-system.org/previews/PR5071/Experimental/FTheoryTools/introduction/.