Skip to content

Stabilize singular_loci's refined Tate fiber type computation (Monte Carlo) with fixed seed#5156

Merged
HereAround merged 3 commits intomasterfrom
OnRareFailures
Jul 28, 2025
Merged

Stabilize singular_loci's refined Tate fiber type computation (Monte Carlo) with fixed seed#5156
HereAround merged 3 commits intomasterfrom
OnRareFailures

Conversation

@HereAround
Copy link
Copy Markdown
Member

@HereAround HereAround commented Jul 24, 2025

Aims to close #4593. (Might need rebasing should #5154 be merged first.)

@HereAround HereAround added topic: FTheoryTools extra-long Also run the extra-long tests during CI. release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes optimization Simpler/more performant code or more/better tests labels Jul 24, 2025
Comment thread experimental/FTheoryTools/src/auxiliary.jl Outdated
Comment thread experimental/FTheoryTools/test/hypersurface_models.jl Outdated
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 24, 2025

Codecov Report

❌ Patch coverage is 81.81818% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.83%. Comparing base (8b3dc60) to head (d16c429).
⚠️ Report is 63 commits behind head on master.

Files with missing lines Patch % Lines
...xperimental/FTheoryTools/src/TateModels/methods.jl 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5156   +/-   ##
=======================================
  Coverage   84.83%   84.83%           
=======================================
  Files         709      709           
  Lines       95508    95506    -2     
=======================================
- Hits        81022    81021    -1     
+ Misses      14486    14485    -1     
Files with missing lines Coverage Δ
.../FTheoryTools/src/HypersurfaceModels/attributes.jl 80.00% <100.00%> (ø)
.../FTheoryTools/src/LiteratureModels/constructors.jl 92.46% <ø> (ø)
...rimental/FTheoryTools/src/TateModels/attributes.jl 86.58% <100.00%> (ø)
...l/FTheoryTools/src/WeierstrassModels/attributes.jl 84.09% <100.00%> (ø)
experimental/FTheoryTools/src/auxiliary.jl 80.76% <100.00%> (+0.23%) ⬆️
...erimental/FTheoryTools/test/hypersurface_models.jl 100.00% <ø> (ø)
experimental/FTheoryTools/test/tate_models.jl 0.00% <ø> (ø)
...perimental/FTheoryTools/test/weierstrass_models.jl 100.00% <ø> (ø)
...xperimental/FTheoryTools/src/TateModels/methods.jl 66.29% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@HereAround HereAround marked this pull request as ready for review July 24, 2025 17:10
Comment thread experimental/FTheoryTools/src/HypersurfaceModels/attributes.jl Outdated
Comment thread experimental/FTheoryTools/docs/src/hypersurface.md Outdated
Comment thread experimental/FTheoryTools/src/LiteratureModels/constructors.jl Outdated
Comment thread experimental/FTheoryTools/src/auxiliary.jl Outdated
@HereAround HereAround force-pushed the OnRareFailures branch 5 times, most recently from ae2d5ac to 267fca2 Compare July 24, 2025 21:31
@HereAround HereAround requested a review from benlorenz July 24, 2025 22:40
@HereAround
Copy link
Copy Markdown
Member Author

@benlorenz When you find the time, please take a look at this. Thank you!

Comment thread experimental/FTheoryTools/src/HypersurfaceModels/attributes.jl Outdated
Comment thread experimental/FTheoryTools/src/TateModels/attributes.jl Outdated
Comment thread experimental/FTheoryTools/src/WeierstrassModels/attributes.jl Outdated
Comment thread experimental/FTheoryTools/src/auxiliary.jl Outdated
Co-authored-by: Benjamin Lorenz <benlorenz@users.noreply.github.com>
@HereAround
Copy link
Copy Markdown
Member Author

Thank you @benlorenz , have just applied your suggestions. Is this PR now ready to be merged? Please take another look.

@HereAround HereAround enabled auto-merge (squash) July 28, 2025 13:46
@HereAround HereAround merged commit 247cb18 into master Jul 28, 2025
32 of 33 checks passed
@HereAround HereAround deleted the OnRareFailures branch July 28, 2025 13:56
@lgoettgens
Copy link
Copy Markdown
Member

Reminder: This has a "release notes: to be added" label, but the initial comment does not have a copy-pasteable block of release notes. Please either choose a different label or add the release notes here.

@HereAround HereAround added release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes and removed release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes labels Sep 1, 2025
@HereAround HereAround changed the title [FTheoryTools] Improve MonteCarlo function [FTheoryTools] Use fixed seed for MonteCarlo function Sep 1, 2025
@HereAround HereAround changed the title [FTheoryTools] Use fixed seed for MonteCarlo function [FTheoryTools] Stabilize singular_loci's refined Tate fiber type computation (Monte Carlo) with fixed seed Sep 1, 2025
@lgoettgens lgoettgens changed the title [FTheoryTools] Stabilize singular_loci's refined Tate fiber type computation (Monte Carlo) with fixed seed Stabilize singular_loci's refined Tate fiber type computation (Monte Carlo) with fixed seed Sep 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

extra-long Also run the extra-long tests during CI. optimization Simpler/more performant code or more/better tests release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes topic: FTheoryTools

Projects

None yet

Development

Successfully merging this pull request may close these issues.

rare tate-models error: Singular loci split vs non-split

3 participants