Stabilize singular_loci's refined Tate fiber type computation (Monte Carlo) with fixed seed#5156
Merged
HereAround merged 3 commits intomasterfrom Jul 28, 2025
Merged
Stabilize singular_loci's refined Tate fiber type computation (Monte Carlo) with fixed seed#5156HereAround merged 3 commits intomasterfrom
singular_loci's refined Tate fiber type computation (Monte Carlo) with fixed seed#5156HereAround merged 3 commits intomasterfrom
Conversation
4811fad to
f0a2f69
Compare
f0a2f69 to
9c7a4d2
Compare
HereAround
commented
Jul 24, 2025
HereAround
commented
Jul 24, 2025
9c7a4d2 to
4c491cc
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5156 +/- ##
=======================================
Coverage 84.83% 84.83%
=======================================
Files 709 709
Lines 95508 95506 -2
=======================================
- Hits 81022 81021 -1
+ Misses 14486 14485 -1
🚀 New features to boost your workflow:
|
4c491cc to
061cbdd
Compare
lgoettgens
reviewed
Jul 24, 2025
ae2d5ac to
267fca2
Compare
267fca2 to
713f627
Compare
713f627 to
7ded9f0
Compare
Member
Author
|
@benlorenz When you find the time, please take a look at this. Thank you! |
benlorenz
reviewed
Jul 28, 2025
Co-authored-by: Benjamin Lorenz <benlorenz@users.noreply.github.com>
Member
Author
|
Thank you @benlorenz , have just applied your suggestions. Is this PR now ready to be merged? Please take another look. |
benlorenz
approved these changes
Jul 28, 2025
Member
|
Reminder: This has a "release notes: to be added" label, but the initial comment does not have a copy-pasteable block of release notes. Please either choose a different label or add the release notes here. |
singular_loci's refined Tate fiber type computation (Monte Carlo) with fixed seed
lgoettgens
referenced
this pull request
Sep 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aims to close #4593. (
Might need rebasing should #5154 be merged first.)