Skip to content

Apply suggestions from code review

d16c429
Select commit
Loading
Failed to load commit list.
Merged

Stabilize singular_loci's refined Tate fiber type computation (Monte Carlo) with fixed seed #5156

Apply suggestions from code review
d16c429
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jul 28, 2025 in 0s

84.83% (+0.00%) compared to 8b3dc60

View this Pull Request on Codecov

84.83% (+0.00%) compared to 8b3dc60

Details

Codecov Report

❌ Patch coverage is 81.81818% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.83%. Comparing base (8b3dc60) to head (d16c429).

Files with missing lines Patch % Lines
...xperimental/FTheoryTools/src/TateModels/methods.jl 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5156   +/-   ##
=======================================
  Coverage   84.83%   84.83%           
=======================================
  Files         709      709           
  Lines       95508    95506    -2     
=======================================
- Hits        81022    81021    -1     
+ Misses      14486    14485    -1     
Files with missing lines Coverage Δ
.../FTheoryTools/src/HypersurfaceModels/attributes.jl 80.00% <100.00%> (ø)
.../FTheoryTools/src/LiteratureModels/constructors.jl 92.46% <ø> (ø)
...rimental/FTheoryTools/src/TateModels/attributes.jl 86.58% <100.00%> (ø)
...l/FTheoryTools/src/WeierstrassModels/attributes.jl 84.09% <100.00%> (ø)
experimental/FTheoryTools/src/auxiliary.jl 80.76% <100.00%> (+0.23%) ⬆️
...erimental/FTheoryTools/test/hypersurface_models.jl 100.00% <ø> (ø)
experimental/FTheoryTools/test/tate_models.jl 0.00% <ø> (ø)
...perimental/FTheoryTools/test/weierstrass_models.jl 100.00% <ø> (ø)
...xperimental/FTheoryTools/src/TateModels/methods.jl 66.29% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.