Add serialization of FinGenAbGroupHom#5196
Conversation
e1c263f to
0b277bd
Compare
There was a problem hiding this comment.
this should also get some pure FinGenAbGroupHom serialization tests (so without any toric stuff in the test). IMO it would even make sense for the PR to be split up into two parts: 1. just adding serialization of FinGenAbGroupHom, 2. using the first PR in a toric setting
That way we could have better release notes for the first part
93c8110 to
fe0bbe5
Compare
Hopefully closer to your desire now, or so I hope. Please take another look. |
lgoettgens
left a comment
There was a problem hiding this comment.
yeah, I should have given you some more than 3 minutes after opening a PR to bring it in good shape :)
fe0bbe5 to
704dc00
Compare
|
Failures in this PR likely due to #5201. |
704dc00 to
3e40fef
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5196 +/- ##
=======================================
Coverage 84.83% 84.84%
=======================================
Files 710 710
Lines 95508 95514 +6
=======================================
+ Hits 81025 81038 +13
+ Misses 14483 14476 -7
🚀 New features to boost your workflow:
|
FinGenAbGroupHom
cc @antonydellavecchia: Splitting-off changes in #5064 as discussed.