Serialize mappings of properties of toric varieties and update QSMDB#5198
Merged
HereAround merged 1 commit intooscar-system:masterfrom Aug 18, 2025
Merged
Serialize mappings of properties of toric varieties and update QSMDB#5198HereAround merged 1 commit intooscar-system:masterfrom
HereAround merged 1 commit intooscar-system:masterfrom
Conversation
b6dde03 to
779b634
Compare
Member
Author
|
@antonydellavecchia This should be the final step before going back to #5064, where I will introduce |
4e85e40 to
926cc16
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5198 +/- ##
=======================================
Coverage 84.83% 84.84%
=======================================
Files 710 710
Lines 95513 95513
=======================================
+ Hits 81029 81035 +6
+ Misses 14484 14478 -6
🚀 New features to boost your workflow:
|
adeb855 to
f788a4f
Compare
[FTheoryTools] Update QSMDB
f788a4f to
7b3200b
Compare
antonydellavecchia
approved these changes
Aug 18, 2025
lgoettgens
referenced
this pull request
Sep 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #5196, which should be discussed/merged first.Content of this PR
map_from_character_lattice_to_torusinvariant_weil_divisor_groupfor toric varieties,map_from_torusinvariant_cartier_divisor_group_to_class_groupfor toric varieties,map_from_torusinvariant_cartier_divisor_group_to_picard_groupfor toric varieties,map_from_torusinvariant_cartier_divisor_group_to_torusinvariant_weil_divisor_groupfor toric varieties,map_from_torusinvariant_weil_divisor_group_to_class_groupfor toric varieties,map_from_torusinvariant_cartier_divisor_group_to_class_groupto the documentation markdown files. This addition is made in this PR.class_group_with_mapandpicard_group_with_map#5064. Instead of saying both the above maps and some of their (co)domains, let us only save/serialize the maps and retrieve objects such as class group, picard group, torus invariant weil divisor group as their (co)domains.cc @antonydellavecchia: Splitting-off changes in #5064 as discussed.