Skip to content

Serialize mappings of properties of toric varieties and update QSMDB#5198

Merged
HereAround merged 1 commit intooscar-system:masterfrom
HereAround:MakeClausHappy-2
Aug 18, 2025
Merged

Serialize mappings of properties of toric varieties and update QSMDB#5198
HereAround merged 1 commit intooscar-system:masterfrom
HereAround:MakeClausHappy-2

Conversation

@HereAround
Copy link
Copy Markdown
Member

@HereAround HereAround commented Aug 15, 2025

Based on #5196, which should be discussed/merged first.

Content of this PR

  • Serialize map_from_character_lattice_to_torusinvariant_weil_divisor_group for toric varieties,
  • Serialize map_from_torusinvariant_cartier_divisor_group_to_class_group for toric varieties,
  • Serialize map_from_torusinvariant_cartier_divisor_group_to_picard_group for toric varieties,
  • Serialize map_from_torusinvariant_cartier_divisor_group_to_torusinvariant_weil_divisor_group for toric varieties,
  • Serialize map_from_torusinvariant_weil_divisor_group_to_class_group for toric varieties,
  • It was forgotten to add the doc string of map_from_torusinvariant_cartier_divisor_group_to_class_group to the documentation markdown files. This addition is made in this PR.
  • Computation of the above maps is improved with an eye towards Introduce class_group_with_map and picard_group_with_map #5064. Instead of saying both the above maps and some of their (co)domains, let us only save/serialize the maps and retrieve objects such as class group, picard group, torus invariant weil divisor group as their (co)domains.
  • The above maps are computed for all QSM models, serialized and the QSM database is updated accordingly.

cc @antonydellavecchia: Splitting-off changes in #5064 as discussed.

@HereAround HereAround added serialization extra-long Also run the extra-long tests during CI. enhancement New feature or request release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes topic: toric geometry labels Aug 15, 2025
@HereAround HereAround marked this pull request as ready for review August 15, 2025 17:57
@HereAround
Copy link
Copy Markdown
Member Author

HereAround commented Aug 15, 2025

@antonydellavecchia This should be the final step before going back to #5064, where I will introduce class_group_with_map and then overhaul/update the serialization accordingly. Please take a look and let me know what you think.

@HereAround HereAround force-pushed the MakeClausHappy-2 branch 2 times, most recently from 4e85e40 to 926cc16 Compare August 15, 2025 20:49
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.84%. Comparing base (5192e9a) to head (926cc16).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5198   +/-   ##
=======================================
  Coverage   84.83%   84.84%           
=======================================
  Files         710      710           
  Lines       95513    95513           
=======================================
+ Hits        81029    81035    +6     
+ Misses      14484    14478    -6     
Files with missing lines Coverage Δ
src/Serialization/ToricGeometry.jl 100.00% <ø> (ø)

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@HereAround HereAround force-pushed the MakeClausHappy-2 branch 8 times, most recently from adeb855 to f788a4f Compare August 17, 2025 08:58
@HereAround HereAround changed the title Serialize map_from_torusinvariant_weil_divisor_group_to_class_group and update QSMDB Serialize mappings of properties of toric varieties and update QSMDB Aug 17, 2025
[FTheoryTools] Update QSMDB
@HereAround HereAround merged commit efea393 into oscar-system:master Aug 18, 2025
30 of 31 checks passed
@HereAround HereAround deleted the MakeClausHappy-2 branch August 18, 2025 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request extra-long Also run the extra-long tests during CI. release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes serialization topic: FTheoryTools topic: toric geometry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants