changelog: check more subprocess exit codes, full checkout to get tags and history#5261
changelog: check more subprocess exit codes, full checkout to get tags and history#5261lgoettgens merged 2 commits intomasterfrom
Conversation
…s and history (for merge-base)
|
I changed the code to use Another option would be to use |
This would make it harder to run from cloned forks, as there the master may be out of date, and the actual master branch is named |
lgoettgens
left a comment
There was a problem hiding this comment.
I don't really understand what the scripts does nor what the changes do, but since this appears to fix the problem, I am fine with merging. Maybe @aaruni96 can do a proper review once they are back in office.
The most important change is the |
Tags and history are probably needed for merge-base command, and
checkmight help debugging such issues.x-ref: #5243 (comment)