Fix f_vector for cones with lineality (and the point)#5716
Merged
benlorenz merged 11 commits intooscar-system:masterfrom Jan 29, 2026
Merged
Fix f_vector for cones with lineality (and the point)#5716benlorenz merged 11 commits intooscar-system:masterfrom
f_vector for cones with lineality (and the point)#5716benlorenz merged 11 commits intooscar-system:masterfrom
Conversation
benlorenz
reviewed
Jan 20, 2026
Member
benlorenz
left a comment
There was a problem hiding this comment.
Looks like the tests are also wrong, Cone2 should indeed have [1,2] and not [0,2].
Comment on lines
+342
to
+343
| ld = pmc.LINEALITY_DIM | ||
| fv = ld == pmc.CONE_DIM ? ZZRingElem[] : pmc.F_VECTOR |
Member
There was a problem hiding this comment.
Suggested change
| ld = pmc.LINEALITY_DIM | |
| fv = ld == pmc.CONE_DIM ? ZZRingElem[] : pmc.F_VECTOR | |
| ld = lineality_dim(C) | |
| fv = ld == dim(C) ? ZZRingElem[] : pmc.F_VECTOR::Polymake.Vector{Polymake.Integer} |
I recommend adding type assertions for polymake properties because julia cannot deduce the return type and also use the existing methods where possible.
f_vector(C::Cone)f_vector for cones with lineality
f_vector for cones with linealityf_vector for cones with lineality (and the point)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5716 +/- ##
==========================================
- Coverage 84.05% 84.04% -0.01%
==========================================
Files 750 750
Lines 103019 102980 -39
==========================================
- Hits 86591 86554 -37
+ Misses 16428 16426 -2
🚀 New features to boost your workflow:
|
benlorenz
approved these changes
Jan 29, 2026
benlorenz
referenced
this pull request
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves #5714.
I have no permission to assign but @lkastner this one's for you.