Skip to content

Fix f_vector for cones with lineality (and the point) #5716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benlorenz merged 11 commits into from
Jan 29, 2026
Merged

Fix f_vector for cones with lineality (and the point) #5716

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
e9520cb
Update properties.jl
imkhln Jan 20, 2026
9945a85
Update properties.jl
imkhln Jan 20, 2026
56355b2
Update properties.jl
imkhln Jan 20, 2026
a37482c
Update properties.jl
imkhln Jan 20, 2026
36df4ef
Update properties.jl
imkhln Jan 20, 2026
f1f4790
fixed f_vector(C::Cone)
Jan 20, 2026
57e7047
fix for f_vector(C::Cone), formatting
Jan 20, 2026
1029001
Update properties.jl
imkhln Jan 20, 2026
983285d
Update properties.jl
imkhln Jan 20, 2026
d30e228
fixed Cone2 f_vector test
Jan 21, 2026
2a752d1
added test for f_vector of 0-dimensional cone (point)
Jan 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/PolyhedralGeometry/Cone/properties.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,8 +339,14 @@ julia> f_vector(square)
"""
function f_vector(C::Cone)
pmc = pm_object(C)
ldim = pmc.LINEALITY_DIM
return Vector{ZZRingElem}(vcat(fill(0, ldim), pmc.F_VECTOR))
ld = lineality_dim(C)
fv = ld == dim(C) ? ZZRingElem[] : pmc.F_VECTOR::Polymake.Vector{Polymake.Integer}
v = zeros(ZZRingElem, ld + length(fv))
v[(ld + 1):end] = fv
if ld > 0
v[ld] = 1
end
return v
end

@doc raw"""
Expand Down
3 changes: 2 additions & 1 deletion test/PolyhedralGeometry/cone.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,8 @@
@test isnothing(faces(Cone2, 1))

@test f_vector(Cone5) == [4, 4]
@test f_vector(Cone2) == [0, 2]
@test f_vector(Cone2) == [1, 2]
@test f_vector(positive_hull([0, 0, 0])) == ZZRingElem[]
@test lineality_dim(Cone5) == 0
@test lineality_dim(Cone2) == 1
@test facet_degrees(Cone5) == fill(2, 4)
Expand Down
Loading