perf(lsp): avoid String cloning for fs.get_document#21040
Merged
graphite-app[bot] merged 1 commit intomainfrom Apr 4, 2026
Merged
perf(lsp): avoid String cloning for fs.get_document#21040graphite-app[bot] merged 1 commit intomainfrom
String cloning for fs.get_document#21040graphite-app[bot] merged 1 commit intomainfrom
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
A-editor
Contributor
There was a problem hiding this comment.
Pull request overview
This PR optimizes the language server’s in-memory document handling by switching document text storage from owned String cloning to shared Arc<str>, reducing allocations/copies when retrieving documents from the LSP file system.
Changes:
- Change
TextDocument.textfromOption<String>toOption<Arc<str>>. - Store file contents in
LSPFileSystemasArc<str>and clone viaArc::cloneinget_document. - Update affected tests to construct document text using
Arc::from(...).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| crates/oxc_language_server/src/lib.rs | Updates TextDocument API to use Option<Arc<str>> to enable cheap clones of document text. |
| crates/oxc_language_server/src/file_system.rs | Stores file contents as Arc<str> and returns TextDocument with Arc clones instead of String clones. |
| crates/oxc_language_server/src/worker.rs | Adjusts tests to match the new TextDocument::new(..., Option<Arc<str>>) signature. |
camc314
approved these changes
Apr 4, 2026
Contributor
Merge activity
|
graphite-app
bot
force-pushed
the
04-04-perf_lsp_avoid_string_cloning_for_fs.get_document_
branch
from
4f147e7 to
da6874a
Compare
graphite-app
bot
deleted the
04-04-perf_lsp_avoid_string_cloning_for_fs.get_document_
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.