staking-async-rc-client: add proof parameter to set_keys #11255
Merged
sigurpol merged 5 commits intostable2512from Mar 4, 2026
Merged
Conversation
…g-async-rc-client-proof-in-set-keys-no-op-validation
sigurpol
force-pushed
the
sigurpol-staking-async-rc-client-proof-in-set-keys-no-op-validation
branch
from
8a8c624 to
58c2ec8
Compare
Contributor
Author
|
/cmd prdoc --audience runtime_dev --bump minor |
Contributor
|
This pull request is amending an existing release. Please proceed with extreme caution,
Emergency Bypass
If you really need to bypass this check: add |
…time_dev --bump minor'
Ank4n
approved these changes
Mar 4, 2026
kianenigma
approved these changes
Mar 4, 2026
sigurpol
deleted the
sigurpol-staking-async-rc-client-proof-in-set-keys-no-op-validation
branch
This was referenced Mar 5, 2026
fellowship-merge-bot bot
added a commit
to polkadot-fellows/runtimes
that referenced
this pull request
Mar 7, 2026
…of of ownership in staking-async-rc-client (#1101) This PR - bumps pallet-society to introduce `kick_member` as per paritytech/polkadot-sdk#11280 - adds support for proof as input parameters (but no real validation since paritytech/polkadot-sdk#1739 has not been backported to `stable2512` ) as per paritytech/polkadot-sdk#11255 - adds support for storage keys deposit on staking-async-rc-client as per paritytech/polkadot-sdk#11242 (10 DOT for Polkadot AssetHub, 1 KSM for Kusama AssetHub) ## TODO - [ ] (if there is time) re-run benchmark for pallet-society on asset-hub-kusama. Not critical since kick_member is meant to be used once in a lifetime but nice to have - [x] CHANGELOG --------- Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Co-authored-by: fellowship-merge-bot[bot] <151052383+fellowship-merge-bot[bot]@users.noreply.github.com>
github-project-automation
bot
moved this from Todo
to Done
in [preview] release tracker
arturgontijo
pushed a commit
to moonbeam-foundation/polkadot-sdk
that referenced
this pull request
Apr 1, 2026
…11255) Add `proof: Vec<u8>` to the `set_keys` extrinsic for forward compatibility with PR paritytech#1739, which introduces real ownership proof validation. Proof validation is a no-op until we backport PR paritytech#1739. Note: I have added `validate:false` for pallet-staking-async-rc-client. The `set_keys` extrinsic has never been deployed on Polkadot/Kusama AH yet, it will be deployed just with release `2.1.0` the first time so it's a brand new API release-wise introduced with the backport of paritytech#10666. --------- Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
proof: Vec<u8>to theset_keysextrinsic for forward compatibility with PR #1739, which introduces real ownership proof validation.Proof validation is a no-op until we backport PR #1739.
Note: I have added
validate:falsefor pallet-staking-async-rc-client. Theset_keysextrinsic has never been deployed on Polkadot/Kusama AH yet, it will be deployed just with release2.1.0the first time so it's a brand new API release-wise introduced with the backport of #10666.